X Tutup
Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

CFn: correct stack ids#13187

Merged
pinzon merged 2 commits intomainfrom
cfn/aws-stack-id-pseudo
Sep 25, 2025
Merged

CFn: correct stack ids#13187
pinzon merged 2 commits intomainfrom
cfn/aws-stack-id-pseudo

Conversation

@simonrw
Copy link
Contributor

@simonrw simonrw commented Sep 24, 2025 •
edited
Loading

Motivation

A customer is facing an issue with their stack deploy (#13159) which extracts parts from the stack id and use them as a resource value. This is because we don't have parity when representing stack ids.

The sample basically performs:

# example stack_id = arn:aws:cloudformation:us-east-1:000000000000:stack/stack-770ab660/79f76a80-8d60-11f0-bd5e-066448b9299d
name = "-".join([
    stack_name,
    "s3logs",
    stack_id.split("/")[2].split("-")[4],
])
# name = stack-770ab660-s3logs-066448b9299d

Note the UUID at the end separated by hyphens. Our stack ids currently use a short uid (i.e. str(uuid.uuid4()).split("-")[0]) which does not have hyphens.

Changes

  • Capture this example in a test
  • Use uuid4 for the trailing ARN component

Closes #13159

@simonrw simonrw added semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes labels Sep 24, 2025
@github-actions
Copy link

github-actions bot commented Sep 24, 2025 •
edited
Loading

Test Results - Preflight, Unit

22 269 tests  ±0   20 528 ✅ ±0   15m 12s ⏱️ -43s
     1 suites ±0    1 741 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit f1a49a9. ± Comparison against base commit f7ffe66.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 24, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 19s ⏱️ -1s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit f1a49a9. ± Comparison against base commit f7ffe66.

♻️ This comment has been updated with latest results.

@simonrw simonrw mentioned this pull request Sep 24, 2025
Closed
1 task
@github-actions
Copy link

github-actions bot commented Sep 24, 2025 •
edited
Loading

Test Results - Alternative Providers

573 tests   330 ✅  25m 31s ⏱️
  1 suites  243 💤
  1 files      0 ❌

Results for commit f1a49a9.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 24, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 38m 45s ⏱️
5 156 tests 4 660 ✅ 496 💤 0 ❌
5 162 runs  4 660 ✅ 502 💤 0 ❌

Results for commit f1a49a9.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 24, 2025 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 57m 25s ⏱️ - 1m 52s
4 782 tests +1  4 446 ✅ +1  336 💤 ±0  0 ❌ ±0 
4 784 runs  +1  4 446 ✅ +1  338 💤 ±0  0 ❌ ±0 

Results for commit f1a49a9. ± Comparison against base commit f7ffe66.

♻️ This comment has been updated with latest results.

@alexrashed alexrashed added the notes: skip Pull request does not have to be mentioned in the release notes label Sep 24, 2025
@simonrw simonrw marked this pull request as ready for review September 24, 2025 16:54
@simonrw simonrw added the review: merge when ready Signals to the reviewer that a PR can be merged if accepted label Sep 25, 2025
@pinzon pinzon merged commit ac927a8 into main Sep 25, 2025
47 checks passed
@pinzon pinzon deleted the cfn/aws-stack-id-pseudo branch September 25, 2025 18:51
@alexrashed alexrashed added this to the 4.9 milestone Sep 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

1 more reviewer

@pinzon pinzon pinzon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes review: merge when ready Signals to the reviewer that a PR can be merged if accepted semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

4.9

Development

Successfully merging this pull request may close these issues.

bug: Cloudformation Fn::Select with nested functions does not validate

3 participants

@simonrw @pinzon @alexrashed
X Tutup