X Tutup
Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

DynamoDB: Bump DDB Local to v3#12879

Merged
giograno merged 4 commits intomainfrom
ddb/patch-v3
Jul 22, 2025
Merged

DynamoDB: Bump DDB Local to v3#12879
giograno merged 4 commits intomainfrom
ddb/patch-v3

Conversation

@giograno
Copy link
Member

@giograno giograno commented Jul 21, 2025 •
edited by viren-nadkarni
Loading

Motivation

Last Friday, we had to skip a LocalStack only test (see #12874) that suddenly started to fail.
We realized that the last version of DynamoDB local (see announcement) now migrated to the SDK for Java 2.x.
Therefore, our custom transformation done in here was not applicable anymore.

(see localstack/localstack-artifacts#44 for more context)

Changes

  • This test re-enables the skipped test.
  • All the fix is actually done in this PR. This PR will be updated with the definitive URL once such a PR gets merged.

Closes PNX-32

@giograno giograno self-assigned this Jul 21, 2025
@giograno giograno added aws:dynamodb Amazon DynamoDB semver: patch Non-breaking changes which can be included in patch releases labels Jul 21, 2025
@github-actions
Copy link

github-actions bot commented Jul 21, 2025 •
edited
Loading

Test Results - Preflight, Unit

21 983 tests  ±0   20 249 ✅ ±0   6m 36s ⏱️ +18s
     1 suites ±0    1 734 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit c8f4ab1. ± Comparison against base commit 36014d4.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jul 21, 2025 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   20m 13s ⏱️ - 1h 25m 32s
1 209 tests  - 3 720  1 141 ✅  - 3 010  68 💤  - 710  0 ❌ ±0 
1 211 runs   - 3 720  1 141 ✅  - 3 010  70 💤  - 710  0 ❌ ±0 

Results for commit c8f4ab1. ± Comparison against base commit 36014d4.

This pull request removes 3720 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jul 21, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 10s ⏱️ +4s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit c8f4ab1. ± Comparison against base commit 36014d4.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jul 21, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   36m 46s ⏱️
1 233 tests 1 165 ✅ 68 💤 0 ❌
1 239 runs  1 165 ✅ 74 💤 0 ❌

Results for commit c8f4ab1.

♻️ This comment has been updated with latest results.

@giograno giograno marked this pull request as ready for review July 21, 2025 13:28
@giograno giograno requested a review from viren-nadkarni as a code owner July 21, 2025 13:28
viren-nadkarni
viren-nadkarni approved these changes Jul 22, 2025
View reviewed changes
Copy link
Member

@viren-nadkarni viren-nadkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

localstack-core/localstack/services/dynamodb/packages.py
JAVASSIST_JAR_URL = f"{MAVEN_REPO_URL}/org/javassist/javassist/3.30.2-GA/javassist-3.30.2-GA.jar"

DDBLOCAL_URL = "https://d1ni2b6xgvw0s0.cloudfront.net/v2.x/dynamodb_local_latest.zip"
DDBLOCAL_URL = "https://d1ni2b6xgvw0s0.cloudfront.net/v3.x/dynamodb_local_latest.zip"
Copy link
Member

@viren-nadkarni viren-nadkarni Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the /v3.x/ have any impact because our tests picked the newer version up despite being pinned to /v2.x/

AWS following the best practices 😛

Copy link
Member Author

@giograno giograno Jul 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:D I dumped it in case they will realize it points to the wrong version!

@viren-nadkarni viren-nadkarni changed the title DDB - re-enable GSI test upon DDBLocal v3 DynamoDB: Bump DDB Local to v3 Jul 22, 2025
@giograno giograno merged commit 71c610e into main Jul 22, 2025
45 checks passed
@giograno giograno deleted the ddb/patch-v3 branch July 22, 2025 07:24
@dfangl dfangl mentioned this pull request Sep 30, 2025
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@viren-nadkarni viren-nadkarni viren-nadkarni approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@giograno giograno

Labels

aws:dynamodb Amazon DynamoDB semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@giograno @viren-nadkarni
X Tutup