X Tutup
Skip to content

Fix y-coordinate typo in createExitData#226

Merged
le-doux merged 1 commit intole-doux:mainfrom
Pirijuamps:fix-create-exit-data
Jul 27, 2023
Merged

Fix y-coordinate typo in createExitData#226
le-doux merged 1 commit intole-doux:mainfrom
Pirijuamps:fix-create-exit-data

Conversation

@Pirijuamps
Copy link
Contributor

Commit 7488171 in part addressed issue #171. In this fix, function ‘createExitData’ was made with a typo and exits are now being created with both coordinates pointing to x.


This PR only corrects the typo on createExitData so y-coordinate is assigned properly.

@frojo
Copy link
Contributor

frojo commented Jul 19, 2023

would it be okay to ask for another reviewer to get this fix pushed soon? it seems adam is busy with other things at the moment

i'm teaching bitsy to a group of students next week and it would be nice if exits and endings worked :)

also totally understand if people are busy! thank you for making bitsy exist and work all these years

@seleb
Copy link
Collaborator

seleb commented Jul 19, 2023

would it be okay to ask for another reviewer to get this fix pushed soon? it seems adam is busy with other things at the moment

i'm teaching bitsy to a group of students next week and it would be nice if exits and endings worked :)

also totally understand if people are busy! thank you for making bitsy exist and work all these years

hey there, the fix is simple but merging the PR requires adam's approval. if you need access to a working version in the meantime though, you have a couple options:

  1. you could download a copy of the editor from before the bug was introduced (e.g. from 36d9a39, go to "browse files" and then "code" > "download zip")
  2. you could download a copy of the current editor and apply this fix manually

if you need any help with running a local copy of the editor, feel free to lmk!

@frojo
Copy link
Contributor

frojo commented Jul 20, 2023

ah sorry, didn't realize adam was the sole approver

ok thank you seleb! I did go ahead and make a temporary fork

Copy link
Owner

@le-doux le-doux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops D:

(thanks for finding this!)

@le-doux le-doux merged commit 6e9d1a4 into le-doux:main Jul 27, 2023
@le-doux
Copy link
Owner

le-doux commented Jul 27, 2023

thanks for working on this y'all! (and thanks for your patience everyone! i've had a lot of personal stuff going on)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

X Tutup