pass charset to String.getBytes() on tests (auth0#128)

lbalmaceda · hzalaz · commit 24901e20461f · 2017-01-04T17:36:24.000-03:00
diff --git a/lib/src/test/java/com/auth0/jwt/algorithms/ECDSAAlgorithmTest.java b/lib/src/test/java/com/auth0/jwt/algorithms/ECDSAAlgorithmTest.java
@@ -427,7 +427,7 @@ public void shouldThrowOnSignWhenSignatureAlgorithmDoesNotExists() throws Except
 
         ECKey key = mock(ECKey.class, withSettings().extraInterfaces(ECPrivateKey.class));
         Algorithm algorithm = new ECDSAAlgorithm(crypto, "some-alg", "some-algorithm", 32, key);
-        algorithm.sign(ES256Header.getBytes());
+        algorithm.sign(ES256Header.getBytes(StandardCharsets.UTF_8));
     }
 
     @Test
diff --git a/lib/src/test/java/com/auth0/jwt/algorithms/HMACAlgorithmTest.java b/lib/src/test/java/com/auth0/jwt/algorithms/HMACAlgorithmTest.java
@@ -38,7 +38,7 @@ public void shouldGetStringBytes() throws Exception {
     public void shouldPassHMAC256Verification() throws Exception {
         String jwt = "eyJhbGciOiJIUzI1NiIsImN0eSI6IkpXVCJ9.eyJpc3MiOiJhdXRoMCJ9.mZ0m_N1J4PgeqWmi903JuUoDRZDBPB7HwkS4nVyWH1M";
         Algorithm algorithmString = Algorithm.HMAC256("secret");
-        Algorithm algorithmBytes = Algorithm.HMAC256("secret".getBytes());
+        Algorithm algorithmBytes = Algorithm.HMAC256("secret".getBytes(StandardCharsets.UTF_8));
         AlgorithmUtils.verify(algorithmString, jwt);
         AlgorithmUtils.verify(algorithmBytes, jwt);
     }
@@ -57,15 +57,15 @@ public void shouldFailHMAC256VerificationWithInvalidSecretBytes() throws Excepti
         exception.expect(SignatureVerificationException.class);
         exception.expectMessage("The Token's Signature resulted invalid when verified using the Algorithm: HmacSHA256");
         String jwt = "eyJhbGciOiJIUzI1NiIsImN0eSI6IkpXVCJ9.eyJpc3MiOiJhdXRoMCJ9.mZ0m_N1J4PgeqWmi903JuUoDRZDBPB7HwkS4nVyWH1M";
-        Algorithm algorithm = Algorithm.HMAC256("not_real_secret".getBytes());
+        Algorithm algorithm = Algorithm.HMAC256("not_real_secret".getBytes(StandardCharsets.UTF_8));
         AlgorithmUtils.verify(algorithm, jwt);
     }
 
     @Test
     public void shouldPassHMAC384Verification() throws Exception {
         String jwt = "eyJhbGciOiJIUzM4NCIsImN0eSI6IkpXVCJ9.eyJpc3MiOiJhdXRoMCJ9.uztpK_wUMYJhrRv8SV-1LU4aPnwl-EM1q-wJnqgyb5DHoDteP6lN_gE1xnZJH5vw";
         Algorithm algorithmString = Algorithm.HMAC384("secret");
-        Algorithm algorithmBytes = Algorithm.HMAC384("secret".getBytes());
+        Algorithm algorithmBytes = Algorithm.HMAC384("secret".getBytes(StandardCharsets.UTF_8));
         AlgorithmUtils.verify(algorithmString, jwt);
         AlgorithmUtils.verify(algorithmBytes, jwt);
     }
@@ -84,15 +84,15 @@ public void shouldFailHMAC384VerificationWithInvalidSecretBytes() throws Excepti
         exception.expect(SignatureVerificationException.class);
         exception.expectMessage("The Token's Signature resulted invalid when verified using the Algorithm: HmacSHA384");
         String jwt = "eyJhbGciOiJIUzM4NCIsImN0eSI6IkpXVCJ9.eyJpc3MiOiJhdXRoMCJ9.uztpK_wUMYJhrRv8SV-1LU4aPnwl-EM1q-wJnqgyb5DHoDteP6lN_gE1xnZJH5vw";
-        Algorithm algorithm = Algorithm.HMAC384("not_real_secret".getBytes());
+        Algorithm algorithm = Algorithm.HMAC384("not_real_secret".getBytes(StandardCharsets.UTF_8));
         AlgorithmUtils.verify(algorithm, jwt);
     }
 
     @Test
     public void shouldPassHMAC512Verification() throws Exception {
         String jwt = "eyJhbGciOiJIUzUxMiIsImN0eSI6IkpXVCJ9.eyJpc3MiOiJhdXRoMCJ9.VUo2Z9SWDV-XcOc_Hr6Lff3vl7L9e5Vb8ThXpmGDFjHxe3Dr1ZBmUChYF-xVA7cAdX1P_D4ZCUcsv3IefpVaJw";
         Algorithm algorithmString = Algorithm.HMAC512("secret");
-        Algorithm algorithmBytes = Algorithm.HMAC512("secret".getBytes());
+        Algorithm algorithmBytes = Algorithm.HMAC512("secret".getBytes(StandardCharsets.UTF_8));
         AlgorithmUtils.verify(algorithmString, jwt);
         AlgorithmUtils.verify(algorithmBytes, jwt);
     }
@@ -111,7 +111,7 @@ public void shouldFailHMAC512VerificationWithInvalidSecretBytes() throws Excepti
         exception.expect(SignatureVerificationException.class);
         exception.expectMessage("The Token's Signature resulted invalid when verified using the Algorithm: HmacSHA512");
         String jwt = "eyJhbGciOiJIUzUxMiIsImN0eSI6IkpXVCJ9.eyJpc3MiOiJhdXRoMCJ9.VUo2Z9SWDV-XcOc_Hr6Lff3vl7L9e5Vb8ThXpmGDFjHxe3Dr1ZBmUChYF-xVA7cAdX1P_D4ZCUcsv3IefpVaJw";
-        Algorithm algorithm = Algorithm.HMAC512("not_real_secret".getBytes());
+        Algorithm algorithm = Algorithm.HMAC512("not_real_secret".getBytes(StandardCharsets.UTF_8));
         AlgorithmUtils.verify(algorithm, jwt);
     }
 
@@ -125,7 +125,7 @@ public void shouldThrowOnVerifyWhenSignatureAlgorithmDoesNotExists() throws Exce
         when(crypto.verifySignatureFor(anyString(), any(byte[].class), any(byte[].class), any(byte[].class)))
                 .thenThrow(NoSuchAlgorithmException.class);
 
-        Algorithm algorithm = new HMACAlgorithm(crypto, "some-alg", "some-algorithm", "secret".getBytes());
+        Algorithm algorithm = new HMACAlgorithm(crypto, "some-alg", "some-algorithm", "secret".getBytes(StandardCharsets.UTF_8));
         String jwt = "eyJhbGciOiJIUzI1NiIsImN0eSI6IkpXVCJ9.eyJpc3MiOiJhdXRoMCJ9.mZ0m_N1J4PgeqWmi903JuUoDRZDBPB7HwkS4nVyWH1M";
         AlgorithmUtils.verify(algorithm, jwt);
     }
@@ -140,7 +140,7 @@ public void shouldThrowOnVerifyWhenTheSecretIsInvalid() throws Exception {
         when(crypto.verifySignatureFor(anyString(), any(byte[].class), any(byte[].class), any(byte[].class)))
                 .thenThrow(InvalidKeyException.class);
 
-        Algorithm algorithm = new HMACAlgorithm(crypto, "some-alg", "some-algorithm", "secret".getBytes());
+        Algorithm algorithm = new HMACAlgorithm(crypto, "some-alg", "some-algorithm", "secret".getBytes(StandardCharsets.UTF_8));
         String jwt = "eyJhbGciOiJIUzI1NiIsImN0eSI6IkpXVCJ9.eyJpc3MiOiJhdXRoMCJ9.mZ0m_N1J4PgeqWmi903JuUoDRZDBPB7HwkS4nVyWH1M";
         AlgorithmUtils.verify(algorithm, jwt);
     }

Original file line number	Diff line number	Diff line change
`@@ -427,7 +427,7 @@ public void shouldThrowOnSignWhenSignatureAlgorithmDoesNotExists() throws Except`
`427`	`427`
`428`	`428`	`ECKey key = mock(ECKey.class, withSettings().extraInterfaces(ECPrivateKey.class));`
`429`	`429`	`Algorithm algorithm = new ECDSAAlgorithm(crypto, "some-alg", "some-algorithm", 32, key);`
`430`		`- algorithm.sign(ES256Header.getBytes());`
	`430`	`+ algorithm.sign(ES256Header.getBytes(StandardCharsets.UTF_8));`
`431`	`431`	`}`
`432`	`432`
`433`	`433`	`@Test`