X Tutup
Skip to content
This repository was archived by the owner on Mar 13, 2022. It is now read-only.

Fix for Travis CI failing on python-base#99

Merged
k8s-ci-robot merged 1 commit intokubernetes-client:masterfrom
micw523:update-ubuntu-ver
Nov 2, 2018
Merged

Fix for Travis CI failing on python-base#99
k8s-ci-robot merged 1 commit intokubernetes-client:masterfrom
micw523:update-ubuntu-ver

Conversation

@micw523
Copy link
Copy Markdown
Contributor

@micw523 micw523 commented Nov 2, 2018

This PR solves the problem introduced into python-base from kubernetes-client/python#665. Should solve build failure reported in #92.
/cc @roycaihw
/this-is-fine

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 2, 2018

@micw523: dog image

Details

In response to this:

This PR solves the problem introduced into python-base from kubernetes-client/python#665. Should solve build failure reported in #92.
/cc @roycaihw
/this-is-fine

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested a review from roycaihw November 2, 2018 20:04
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 2, 2018
@micw523 micw523 mentioned this pull request Nov 2, 2018
Merged
@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 2, 2018

Codecov Report

Merging #99 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #99   +/-   ##
=======================================
  Coverage   91.72%   91.72%           
=======================================
  Files          13       13           
  Lines        1136     1136           
=======================================
  Hits         1042     1042           
  Misses         94       94

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83ebb9d...be621d3. Read the comment docs.

roycaihw
roycaihw approved these changes Nov 2, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@roycaihw roycaihw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2018
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 2, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: micw523, roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2018
@k8s-ci-robot k8s-ci-robot merged commit 4da0fcc into kubernetes-client:master Nov 2, 2018
@micw523 micw523 deleted the update-ubuntu-ver branch November 2, 2018 20:17
@micw523 micw523 mentioned this pull request Nov 9, 2018
Closed
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@roycaihw roycaihw roycaihw approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@roycaihw roycaihw

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@micw523 @k8s-ci-robot @codecov-io @roycaihw
X Tutup