X Tutup
Skip to content
This repository was archived by the owner on Mar 13, 2022. It is now read-only.

Allow setting maxsize for PoolManager#18

Merged
mbohlool merged 2 commits intokubernetes-client:masterfrom
yuvipanda:connpool-maxsize
Jul 9, 2017
Merged

Allow setting maxsize for PoolManager#18
mbohlool merged 2 commits intokubernetes-client:masterfrom
yuvipanda:connpool-maxsize

Conversation

@yuvipanda
Copy link
Copy Markdown
Contributor

@yuvipanda yuvipanda commented Jul 9, 2017 •
edited
Loading

@yuvipanda
Copy link
Copy Markdown
Contributor Author

yuvipanda commented Jul 9, 2017

I'm guessing I've to manually bump the submodule ref in client-python after this gets merged?

@yuvipanda yuvipanda mentioned this pull request Jul 9, 2017
Closed
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jul 9, 2017 •
edited
Loading

Codecov Report

Merging #18 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #18   +/-   ##
=======================================
  Coverage   94.69%   94.69%           
=======================================
  Files           9        9           
  Lines         698      698           
=======================================
  Hits          661      661           
  Misses         37       37

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26cb526...d339d7c. Read the comment docs.

mbohlool
mbohlool reviewed Jul 9, 2017
View reviewed changes
configuration.py Outdated
# per pool. Increasing this is useful for cases when you are
# making a lot of possibly parallel requests to the same host,
# which is often the case here.
self.connection_pool_maxsize = 1
Copy link
Copy Markdown
Contributor

@mbohlool mbohlool Jul 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will change default value to 1. I don't know what default value is, but it is safer to set this to None and add an if statement in the other file to set it if not none.

Copy link
Copy Markdown
Contributor Author

@yuvipanda yuvipanda Jul 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per http://urllib3.readthedocs.io/en/latest/advanced-usage.html the default value is 1 but I agree we should use None and pass through. Shall amend.

Copy link
Copy Markdown
Contributor Author

@yuvipanda yuvipanda Jul 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@mbohlool mbohlool merged commit d301e20 into kubernetes-client:master Jul 9, 2017
@yuvipanda yuvipanda mentioned this pull request Jul 9, 2017
Closed
mbohlool added a commit to kubernetes-client/python that referenced this pull request Jul 9, 2017
@mbohlool
Merge pull request #293 from yuvipanda/update-maxsize
e6e7b71 
Submodule bump for kubernetes-client/python-base#18
@yliaog yliaog mentioned this pull request Nov 27, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mbohlool mbohlool mbohlool left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yuvipanda @codecov-io @mbohlool
X Tutup