X Tutup
Skip to content
This repository was archived by the owner on Mar 13, 2022. It is now read-only.

[WIP] Remove absolute dependence of adal#101

Closed
micw523 wants to merge 1 commit intokubernetes-client:masterfrom
micw523:adal
Closed

[WIP] Remove absolute dependence of adal#101
micw523 wants to merge 1 commit intokubernetes-client:masterfrom
micw523:adal

Conversation

@micw523
Copy link
Copy Markdown
Contributor

@micw523 micw523 commented Nov 12, 2018

Fixes kubernetes-client/python#668
Fixes kubernetes-client/python#645
Will need to be updated concurrently with a PR from the main repo.
Task list:
[x] Use try / except to handle adal import
[ ] modify setup file to add the adal option [main repo]
[ ] add adal option to the install section of documentation [main repo]
[ ] change the main test interface to install k8s with adal
[ ] add a test env and a minimal test that does not include adal

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 12, 2018
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 12, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: micw523
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: roycaihw

If they are not already assigned, you can assign the PR to them by writing /assign @roycaihw in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 12, 2018
@micw523
Copy link
Copy Markdown
Contributor Author

micw523 commented Nov 12, 2018

/uncc mbohlool
/uncc yliaog
/hold
/joke

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 12, 2018

@micw523: Did you hear about the guy who invented Lifesavers? They say he made a mint.

Details

In response to this:

/uncc mbohlool
/uncc yliaog
/hold
/joke

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 12, 2018
@tomplus tomplus mentioned this pull request Dec 11, 2018
Merged
@dims
Copy link
Copy Markdown

dims commented Dec 16, 2018

@micw523 @iamneha since this is a WIP and has a task list ...

  • @micw523 can you please turn the task list into issues?
  • Also let's close this and leave 108 as we need to pick one or the other :)

Sounds good?

@micw523 micw523 closed this Jan 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@micw523 @k8s-ci-robot @dims
X Tutup