X Tutup
Skip to content

Update py.test to pytest#975

Merged
k8s-ci-robot merged 1 commit intokubernetes-client:masterfrom
micw523:patch-1
Oct 9, 2019
Merged

Update py.test to pytest#975
k8s-ci-robot merged 1 commit intokubernetes-client:masterfrom
micw523:patch-1

Conversation

@micw523
Copy link
Copy Markdown
Contributor

@micw523 micw523 commented Oct 2, 2019

Refer to this stackoverflow post.

This should provide identical pytest coverage while allowing us to stay modern :)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 2, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 2, 2019
[testenv:py27-functional]
commands =
python -V
{toxinidir}/scripts/kube-init.sh py.test -vvv -s []
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we update L12 as well?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch - updated!

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 4, 2019
@roycaihw
Copy link
Copy Markdown
Member

roycaihw commented Oct 4, 2019

/approve

please squash the commits

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: micw523, roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2019
@yliaog
Copy link
Copy Markdown
Contributor

yliaog commented Oct 8, 2019

/assign @roycaihw

@roycaihw
Copy link
Copy Markdown
Member

roycaihw commented Oct 9, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2019
@k8s-ci-robot k8s-ci-robot merged commit 2dfb303 into kubernetes-client:master Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

X Tutup