X Tutup
Skip to content

Update base module and regenerate client for 9.0.0b1#748

Merged
k8s-ci-robot merged 4 commits intokubernetes-client:masterfrom
roycaihw:base-update
Feb 7, 2019
Merged

Update base module and regenerate client for 9.0.0b1#748
k8s-ci-robot merged 4 commits intokubernetes-client:masterfrom
roycaihw:base-update

Conversation

@roycaihw
Copy link
Copy Markdown
Member

@roycaihw roycaihw commented Feb 6, 2019

contains several improvements. Note that moving adal under extra_require is still WIP in main repo (merged in python-base repo)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 6, 2019
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 6, 2019
@roycaihw
Copy link
Copy Markdown
Member Author

roycaihw commented Feb 6, 2019

/assign @yliaog

@yliaog
Copy link
Copy Markdown
Contributor

yliaog commented Feb 7, 2019

kubernetes/client/api_client.py.orig is in the commit, is it intentional?

@roycaihw
Copy link
Copy Markdown
Member Author

roycaihw commented Feb 7, 2019

@yliaog it's from https://github.com/kubernetes-client/gen/blob/d0821e65aa3474ce69b6bd64219d9c2082c391b7/openapi/python.sh#L64-L66

removed. I don't think we need to keep the patch backup here. I will send a change to gen to clean it up (like what we do for:

python/scripts/update-client.sh

Line 73 in 7486e19

git apply "${SCRIPT_ROOT}/rest_client_patch.diff"

@roycaihw roycaihw mentioned this pull request Feb 7, 2019
Merged
@roycaihw
Copy link
Copy Markdown
Member Author

roycaihw commented Feb 7, 2019

the backup turns out to be from an unintentional mismatch. sent a cleanup kubernetes-client/gen#102

@yliaog
Copy link
Copy Markdown
Contributor

yliaog commented Feb 7, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 7, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roycaihw, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 67d30a0 into kubernetes-client:master Feb 7, 2019
@roycaihw roycaihw deleted the base-update branch February 7, 2019 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mbohlool mbohlool Awaiting requested review from mbohlool

@yliaog yliaog Awaiting requested review from yliaog

Assignees

@yliaog yliaog

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@roycaihw @yliaog @k8s-ci-robot
X Tutup