Improve close behavior some.#700
Merged
k8s-ci-robot merged 1 commit intokubernetes-client:masterfrom Sep 20, 2019
Merged
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
yue9944882
reviewed
Sep 16, 2019
| protected void handleMessage(int stream, InputStream inStream) throws IOException { | ||
| OutputStream out = getSocketInputOutputStream(stream); | ||
| ByteStreams.copy(inStream, out); | ||
| inStream.close(); |
Member
There was a problem hiding this comment.
nit: how about closing the stream in a try-finally block?
brendandburns
force-pushed
the
close
branch
from
d85e766 to
0913763
Compare
Contributor
Author
|
Comment addressed please take another look. |
Member
ci is failing on formatting error |
brendandburns
force-pushed
the
close
branch
from
0913763 to
d23be42
Compare
Contributor
Author
|
CI is fixed. THanks! |
k8s-ci-robot
added
the
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possible fixes for #687
@ceeaspb