X Tutup
Skip to content

Shutdown original queue before override#3737

Merged
k8s-ci-robot merged 1 commit intokubernetes-client:masterfrom
yuzp1996:master
Oct 14, 2024
Merged

Shutdown original queue before override#3737
k8s-ci-robot merged 1 commit intokubernetes-client:masterfrom
yuzp1996:master

Conversation

@yuzp1996
Copy link
Copy Markdown
Contributor

@yuzp1996 yuzp1996 commented Oct 12, 2024 •
edited
Loading

When overriding the workQueue for the controller, the original queue must be shut down to avoid thread leakage. If the original queue is not shut down here, it will remain active even after the controller is shut down. This is because the controller's queue has been replaced by the newly created queue.

Related Issue: #3738

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 12, 2024
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 12, 2024

Welcome @yuzp1996!

It looks like this is your first PR to kubernetes-client/java 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/java has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 12, 2024
@brendandburns
Copy link
Copy Markdown
Contributor

brendandburns commented Oct 13, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2024
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, yuzp1996

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2024
@yuzp1996
When override workQueue for the controller should shutdown the origin…
6041de7 
…al queue incase thread leakage

Issue: kubernetes-client#3738

Signed-off-by: yuzhipeng <zpyu@alauda.io>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2024
@yuzp1996
Copy link
Copy Markdown
Contributor Author

yuzp1996 commented Oct 13, 2024

@brendandburns I have fixed the format error. Could you please take a look again and give your LGTM or approval? Thank you.

yuzp1996 pushed a commit to alauda/java that referenced this pull request Oct 14, 2024
@alaudabot @yuzp1996
Fix thread leakage when override controller queue with withQueue
8442a84 
Official Issue kubernetes-client#3738

Official PR kubernetes-client#3737

Signed-off-by: yuzhipeng <zpyu@alauda.io>
@yuzp1996 yuzp1996 mentioned this pull request Oct 14, 2024
Merged
@brendandburns
Copy link
Copy Markdown
Contributor

brendandburns commented Oct 14, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2024
@k8s-ci-robot k8s-ci-robot merged commit 6bc1880 into kubernetes-client:master Oct 14, 2024
@yuzp1996 yuzp1996 mentioned this pull request Oct 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

@yue9944882 yue9944882 Awaiting requested review from yue9944882

Assignees

@brendandburns brendandburns

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yuzp1996 @k8s-ci-robot @brendandburns
X Tutup