Add Windows to our build matrix.#2000
Merged
k8s-ci-robot merged 5 commits intokubernetes-client:masterfrom Nov 25, 2021
Merged
Conversation
k8s-ci-robot
added
approved
brendandburns
force-pushed
the
build-matrix
branch
2 times, most recently
from
c0aec5b to
a8b4ba5
Compare
k8s-ci-robot
added
size/S
brendandburns
force-pushed
the
build-matrix
branch
from
a8b4ba5 to
5feb527
Compare
Contributor
Author
|
/hold This is going to take more work :( |
k8s-ci-robot
added
the
do-not-merge/hold
brendandburns
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
brendandburns
force-pushed
the
build-matrix
branch
from
5feb527 to
4ed746c
Compare
brendandburns
force-pushed
the
build-matrix
branch
from
4ed746c to
bad85c5
Compare
k8s-ci-robot
added
size/L
brendandburns
force-pushed
the
build-matrix
branch
2 times, most recently
from
252e940 to
be50feb
Compare
brendandburns
force-pushed
the
build-matrix
branch
5 times, most recently
from
021b471 to
c98f17e
Compare
brendandburns
force-pushed
the
build-matrix
branch
from
c98f17e to
38c553a
Compare
brendandburns
force-pushed
the
build-matrix
branch
from
ebb4034 to
cadf986
Compare
brendandburns
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Contributor
Author
|
/hold remove @yue9944882 this is ready for review. I will add macos in a separate PR. |
brendandburns
removed
the
do-not-merge/hold
yue9944882
reviewed
Nov 25, 2021
Member
yue9944882
left a comment
yue9944882
left a comment
There was a problem hiding this comment.
@brendandburns this is awesome!!
/lgtm
/approve
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, yue9944882 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.