Fix arguments to dockerfiles#1899
Conversation
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Welcome @anirudha-ptr! |
|
I signed it |
|
cc @yue9944882 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anirudha-ptr, yue9944882 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Couple of issues with Dockerfiles in client-java-contrib:
The base image is a private image in Dockerfile.gen. It should take the base image as an argument with default values.
Dockerfile.gen-base is using variables and doesnt define them as arguments:
${OPENAPI_GENERATOR_USER_ORG}
OPENAPI_GENERATOR_COMMIT
Because of this the Dockerfile doesn't build.
#1897