X Tutup
Skip to content
This repository was archived by the owner on Aug 15, 2022. It is now read-only.

Softlayer custom image#11453

Merged
szkl merged 2 commits intomasterfrom
softlayer-custom-image
Oct 9, 2017
Merged

Softlayer custom image#11453
szkl merged 2 commits intomasterfrom
softlayer-custom-image

Conversation

@rjeczalik
Copy link
Member

This PR:

  • fixes provider which errornously overwritten image attribute set by user
  • does not set image when block_device_template_group_gid is set, as those fields are exclusive

Please take a look.

@rjeczalik rjeczalik requested a review from szkl October 9, 2017 12:48
@codecov-io
Copy link

codecov-io commented Oct 9, 2017

Codecov Report

Merging #11453 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master   #11453   +/-   ##
=======================================
  Coverage    30.2%    30.2%           
=======================================
  Files         101      101           
  Lines       11425    11425           
=======================================
  Hits         3456     3456           
  Misses       7572     7572           
  Partials      397      397

@szkl szkl merged commit 5eb73e9 into master Oct 9, 2017
@szkl szkl deleted the softlayer-custom-image branch October 9, 2017 13:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

X Tutup