This repository was archived by the owner on Aug 15, 2022. It is now read-only.
Define user proxy and tunnel URIs in the configuration#11405
Merged
Define user proxy and tunnel URIs in the configuration#11405
Conversation
Signed-off-by: Sonmez Kartal <sonmez@koding.com>
cihangir
approved these changes
Aug 14, 2017
gokmen
approved these changes
Aug 14, 2017
rjeczalik
approved these changes
Aug 15, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sonmez Kartal sonmez@koding.com
Description
Simplify setting of user proxy/tunnel URI.
Motivation and Context
Proxifier module is computing the user proxy/tunnel URIs based on environment runtime.
I've simplified this process by setting the user proxy/tunnel URIs in the configuration of each environment. Proxifier module does not need to have conditional statement branches to figure out what endpoint to use.
How Has This Been Tested?
Types of changes