Throw when passed strings on Object.prototype#21
Merged
dougwilson merged 1 commit intojshttp:masterfrom Jan 3, 2021
Merged
Conversation
dougwilson
suggested changes
Dec 25, 2020
Contributor
dougwilson
left a comment
dougwilson
left a comment
There was a problem hiding this comment.
Unfortunately this object is a public API, so changing the prototype within the same major version is going to be painful. Can we implement the same behavior with something like Object.prototype.hasOwnProperty instead?
EvanHahn
force-pushed
the
avoid-object-prototype
branch
from
f67b43e to
afa5f0b
Compare
Contributor
Author
|
Updated with a new utility function, |
dougwilson
force-pushed
the
avoid-object-prototype
branch
from
afa5f0b to
16cbd05
Compare
dougwilson
force-pushed
the
avoid-object-prototype
branch
from
16cbd05 to
90c1829
Compare
Contributor
|
Thanks @EvanHahn ! I updated the PR to perform the check on all the lookups as well, so they are all guarded now as appropriate. |
dougwilson
approved these changes
Jan 3, 2021
EvanHahn
added a commit
to EvanHahn/evanhahn-dot-com
that referenced
this pull request
Jan 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
'constructor' in Object.prototype,status('constructor')would returnObject.prototype.constructor. This was true for any all-lowercase key, which is currently__proto__andconstructor.Here's the meat of the change: