X Tutup
Skip to content

Fix domain lock to be case-insensitive by normalizing domain values to lowercase #1400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sanex3339 merged 1 commit into from
Mar 22, 2026
+46 −1
Merged

Fix domain lock to be case-insensitive by normalizing domain values to lowercase #1400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ Change Log
v5.4.1
---
* Fixed missing space between keywords (`return`, `throw`, `typeof`) and Unicode surrogate pair identifiers in compact mode. Fixes https://github.com/javascript-obfuscator/javascript-obfuscator/issues/1112
* Fixed `domainLock` being case-sensitive — domain values are now normalized to lowercase. Fixes https://github.com/javascript-obfuscator/javascript-obfuscator/issues/1182
* Removed `source-map-support` runtime dependency. Use `node --enable-source-maps` instead. Fixes https://github.com/javascript-obfuscator/javascript-obfuscator/issues/1149

v5.4.0
Expand Down
2 changes: 1 addition & 1 deletion src/options/normalizer-rules/DomainLockRule.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export const DomainLockRule: TOptionsNormalizerRule = (options: IOptions): IOpti
const normalizedDomains: string[] = [];

for (const domain of options.domainLock) {
normalizedDomains.push(Utils.extractDomainFrom(domain));
normalizedDomains.push(Utils.extractDomainFrom(domain).toLowerCase());
}

options = {
Expand Down
1 change: 1 addition & 0 deletions test/functional-tests/issues/fixtures/issue1182.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
var result = 42;
43 changes: 43 additions & 0 deletions test/functional-tests/issues/issue1182.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
import { assert } from 'chai';

import { DomainLockRule } from '../../../src/options/normalizer-rules/DomainLockRule';
import { IOptions } from '../../../src/interfaces/options/IOptions';

//
// https://github.com/javascript-obfuscator/javascript-obfuscator/issues/1182
//
describe('Issue #1182', () => {
describe('domainLock should be case-insensitive', () => {
it('should normalize mixed-case domain to lowercase', () => {
const options = DomainLockRule({
domainLock: ['Example.COM']
} as IOptions);

assert.deepEqual(options.domainLock, ['example.com']);
});

it('should normalize domain with subdomain to lowercase', () => {
const options = DomainLockRule({
domainLock: ['.Example.COM']
} as IOptions);

assert.deepEqual(options.domainLock, ['.example.com']);
});

it('should normalize multiple mixed-case domains', () => {
const options = DomainLockRule({
domainLock: ['Foo.Bar.COM', 'EXAMPLE.ORG']
} as IOptions);

assert.deepEqual(options.domainLock, ['foo.bar.com', 'example.org']);
});

it('should not change already-lowercase domains', () => {
const options = DomainLockRule({
domainLock: ['example.com']
} as IOptions);

assert.deepEqual(options.domainLock, ['example.com']);
});
});
});
Loading
X Tutup