forked from getredash/redash
-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathtest_changes.py
More file actions
78 lines (59 loc) · 2.54 KB
/
test_changes.py
File metadata and controls
78 lines (59 loc) · 2.54 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
from tests import BaseTestCase
from redash.models import db, Query, Change, ChangeTrackingMixin
def create_object(factory):
obj = Query(name='Query',
description='',
query_text='SELECT 1',
user=factory.user,
data_source=factory.data_source,
org=factory.org)
return obj
class TestChangesProperty(BaseTestCase):
def test_returns_initial_state(self):
obj = create_object(self.factory)
for change in Change.query.filter(Change.object == obj):
self.assertIsNone(change.change['previous'])
class TestLogChange(BaseTestCase):
def obj(self):
obj = Query(name='Query',
description='',
query_text='SELECT 1',
user=self.factory.user,
data_source=self.factory.data_source,
org=self.factory.org)
return obj
def test_properly_logs_first_creation(self):
obj = create_object(self.factory)
obj.record_changes(changed_by=self.factory.user)
change = Change.last_change(obj)
self.assertIsNotNone(change)
self.assertEqual(change.object_version, 1)
def test_skips_unnecessary_fields(self):
obj = create_object(self.factory)
obj.record_changes(changed_by=self.factory.user)
change = Change.last_change(obj)
self.assertIsNotNone(change)
self.assertEqual(change.object_version, 1)
for field in ChangeTrackingMixin.skipped_fields:
self.assertNotIn(field, change.change)
def test_properly_log_modification(self):
obj = create_object(self.factory)
obj.record_changes(changed_by=self.factory.user)
obj.name = 'Query 2'
obj.description = 'description'
db.session.flush()
obj.record_changes(changed_by=self.factory.user)
change = Change.last_change(obj)
self.assertIsNotNone(change)
# TODO: https://github.com/getredash/redash/issues/1550
# self.assertEqual(change.object_version, 2)
self.assertEqual(change.object_version, obj.version)
self.assertIn('name', change.change)
self.assertIn('description', change.change)
def test_logs_create_method(self):
q = Query(name='Query', description='', query_text='',
user=self.factory.user, data_source=self.factory.data_source,
org=self.factory.org)
change = Change.last_change(q)
self.assertIsNotNone(change)
self.assertEqual(q.user, change.user)