mwh pointed out _Filemodule.c is generated. So to fix the memory leak

neal.norwitz · neal.norwitz · commit 01ca7aa6bb4d · 2006-01-25T05:42:22.000Z
this file (the source) must be fixed. Why isn't there a comment at the top saying the file is generated and why are both the source and generated file checked in? Bootstrap problem? Will backport. git-svn-id: http://svn.python.org/projects/python/trunk@42179 6015fed2-1504-0410-9fe1-9d1591cc4771
diff --git a/Mac/Modules/file/filesupport.py b/Mac/Modules/file/filesupport.py
@@ -302,11 +302,10 @@ def getargsCheck(self, name):
                 char *path = NULL;
                 if (!PyArg_Parse(v, "et", Py_FileSystemDefaultEncoding, &path))
                         return 0;
-                if ( (err=FSPathMakeRef(path, fsr, NULL)) ) {
+                if ( (err=FSPathMakeRef(path, fsr, NULL)) )
                         PyMac_Error(err);
-                        return 0;
-                }
-                return 1;
+                PyMem_Free(path);
+                return !err;
         }
         /* XXXX Should try unicode here too */
         /* Otherwise we try to go via an FSSpec */
