restored support for String-to-ContextResource conversion (SPR-8383)

jhoeller · jhoeller · commit fece2c112502 · 2011-06-15T15:46:41.000Z
diff --git a/org.springframework.beans/src/main/java/org/springframework/beans/TypeConverterDelegate.java b/org.springframework.beans/src/main/java/org/springframework/beans/TypeConverterDelegate.java
@@ -223,7 +223,8 @@ else if (convertedValue instanceof String && !requiredType.isInstance(convertedV
 				}
 				if (editor != null) {
 					msg.append(": PropertyEditor [").append(editor.getClass().getName()).append(
-							"] returned inappropriate value");
+							"] returned inappropriate value of type [").append(
+							ClassUtils.getDescriptiveType(convertedValue)).append("]");
 					throw new IllegalArgumentException(msg.toString());
 				}
 				else {
diff --git a/org.springframework.beans/src/main/java/org/springframework/beans/support/ResourceEditorRegistrar.java b/org.springframework.beans/src/main/java/org/springframework/beans/support/ResourceEditorRegistrar.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2010 the original author or authors.
+ * Copyright 2002-2011 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -34,6 +34,7 @@
 import org.springframework.beans.propertyeditors.InputStreamEditor;
 import org.springframework.beans.propertyeditors.URIEditor;
 import org.springframework.beans.propertyeditors.URLEditor;
+import org.springframework.core.io.ContextResource;
 import org.springframework.core.io.Resource;
 import org.springframework.core.io.ResourceEditor;
 import org.springframework.core.io.ResourceLoader;
@@ -84,6 +85,7 @@ public ResourceEditorRegistrar(ResourceLoader resourceLoader) {
 	public void registerCustomEditors(PropertyEditorRegistry registry) {
 		ResourceEditor baseEditor = new ResourceEditor(this.resourceLoader);
 		doRegisterEditor(registry, Resource.class, baseEditor);
+		doRegisterEditor(registry, ContextResource.class, baseEditor);
 		doRegisterEditor(registry, InputStream.class, new InputStreamEditor(baseEditor));
 		doRegisterEditor(registry, InputSource.class, new InputSourceEditor(baseEditor));
 		doRegisterEditor(registry, File.class, new FileEditor(baseEditor));
diff --git a/org.springframework.context/src/test/java/org/springframework/beans/ResourceTestBean.java b/org.springframework.context/src/test/java/org/springframework/beans/ResourceTestBean.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2010 the original author or authors.
+ * Copyright 2002-2011 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -19,6 +19,7 @@
 import java.io.InputStream;
 import java.util.Map;
 
+import org.springframework.core.io.ContextResource;
 import org.springframework.core.io.Resource;
 
 /**
@@ -29,6 +30,8 @@ public class ResourceTestBean {
 
 	private Resource resource;
 
+	private ContextResource contextResource;
+
 	private InputStream inputStream;
 
 	private Resource[] resourceArray;
@@ -47,22 +50,30 @@ public ResourceTestBean(Resource resource, InputStream inputStream) {
 	}
 
 
+	public Resource getResource() {
+		return resource;
+	}
+
 	public void setResource(Resource resource) {
 		this.resource = resource;
 	}
 
-	public void setInputStream(InputStream inputStream) {
-		this.inputStream = inputStream;
+	public ContextResource getContextResource() {
+		return contextResource;
 	}
 
-	public Resource getResource() {
-		return resource;
+	public void setContextResource(ContextResource contextResource) {
+		this.contextResource = contextResource;
 	}
 
 	public InputStream getInputStream() {
 		return inputStream;
 	}
 
+	public void setInputStream(InputStream inputStream) {
+		this.inputStream = inputStream;
+	}
+
 	public Resource[] getResourceArray() {
 		return resourceArray;
 	}
diff --git a/org.springframework.context/src/test/java/org/springframework/context/support/ClassPathXmlApplicationContextTests-resourceImport.xml b/org.springframework.context/src/test/java/org/springframework/context/support/ClassPathXmlApplicationContextTests-resourceImport.xml
@@ -7,6 +7,9 @@
 		<property name="resource">
 			<value>test.properties</value>
 		</property>
+		<property name="contextResource">
+			<value>testBeans.properties</value>
+		</property>
 		<property name="inputStream">
 			<value>classpath:org/springframework/beans/factory/xml/test.properties</value>
 		</property>

Original file line number	Diff line number	Diff line change
`@@ -223,7 +223,8 @@ else if (convertedValue instanceof String && !requiredType.isInstance(convertedV`
`223`	`223`	`}`
`224`	`224`	`if (editor != null) {`
`225`	`225`	`msg.append(": PropertyEditor [").append(editor.getClass().getName()).append(`
`226`		`- "] returned inappropriate value");`
	`226`	`+ "] returned inappropriate value of type [").append(`
	`227`	`+ ClassUtils.getDescriptiveType(convertedValue)).append("]");`
`227`	`228`	`throw new IllegalArgumentException(msg.toString());`
`228`	`229`	`}`
`229`	`230`	`else {`