Bug: no assert... in test ArraysTest.testArraysBinarySearchString2

abego · abego · commit 9036e1052734 · 2017-06-28T15:10:56.000+02:00
The assert was commented-out because it failed.

The bug was is the test code: no comparator was passed to
Arrays.binarySearch, thus given an undefined result as the array was
not sorted in natural order, but a "user defined" one.
diff --git a/tests/net.sf.j2s.test.junit/src/net/sf/j2s/test/junit/ArraysTest.java b/tests/net.sf.j2s.test.junit/src/net/sf/j2s/test/junit/ArraysTest.java
@@ -84,14 +84,17 @@ public int compare(String o1, String o2) {
 	}
 	public void testArraysBinarySearchString2() {
 		String[] bs = new String[] {"Hello", "World", "JavaScript", "AJAX", "SWT", "JavaScript"};
-		Arrays.sort(bs, new Comparator<String>() {
+		Comparator<String> comp = new Comparator<String>() {
 			public int compare(String o1, String o2) {
 				return o1.charAt(1) - o2.charAt(1);
 			}
-		});
-//		int idx = Arrays.binarySearch(bs, "SWT");
-//		assertEquals(1, idx);
+		};
+		Arrays.sort(bs, comp);
+		
+		int idx = Arrays.binarySearch(bs, "SWT", comp);
+		assertEquals(1, idx);
 	}
+
 	public void testArraysEqualsString2() {
 		String[] bs1 = new String[] {"Hello", "World", "JavaScript", "AJAX", "SWT", "JavaScript"};
 		String[] bs2 = new String[] {"Hello", "World", "JavaScript", "AJAX", "SWT", "JavaScript"};
