feat(modal): expose snapBreakpoint on swipe-to-close modals#31002
Open
aeharding wants to merge 1 commit intoionic-team:mainfrom
Open
feat(modal): expose snapBreakpoint on swipe-to-close modals#31002aeharding wants to merge 1 commit intoionic-team:mainfrom
aeharding wants to merge 1 commit intoionic-team:mainfrom
Conversation
|
@aeharding is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
brandyscarney
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #31001
What is the current behavior?
No
snapBreakpointWhat is the new behavior?
Expose
snapBreakpointonionDragEndevent forswipe-to-closedialogs.Does this introduce a breaking change?
Other information
Testing with Voyager and works great! aeharding/voyager#2227