X Tutup
Skip to content

refactor list_seeds in prep for fastapi#11988

Merged
RayBB merged 1 commit intomasterfrom
fastapi-prep/list_seeds
Mar 3, 2026
Merged

refactor list_seeds in prep for fastapi#11988
RayBB merged 1 commit intomasterfrom
fastapi-prep/list_seeds

Conversation

@RayBB
Copy link
Collaborator

@RayBB RayBB commented Mar 3, 2026

No description provided.

@RayBB
Copy link
Collaborator Author

RayBB commented Mar 3, 2026

AI review

Changes

  • Extracts seed processing into a reusable static method
  • Moves _save() call inside the extracted method
  • No functional behavior change, just code reorganization
    Potential Risk
    Error handling changed: The original code added seeds, then removed seeds, then saved. If adding succeeds but removing fails, the original code would still save. Now the method does all three in one go - any failure rolls back the whole operation (which is actually safer).
    Verdict
    Low risk - This is a straightforward refactor.

@RayBB RayBB merged commit 84515fb into master Mar 3, 2026
8 checks passed
@RayBB RayBB deleted the fastapi-prep/list_seeds branch March 3, 2026 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

X Tutup