Migrate partials endpoint from querystring-based routing to path-based routing#11828
Merged
Migrate partials endpoint from querystring-based routing to path-based routing#11828
Conversation
Collaborator
Author
|
@jimchamp I think you've driven a lot of the partials code so I'd especially like your input on this one. |
RayBB
changed the title
Collaborator
|
This all seems fine to me (rslgtm). At one point, I think that we were passing an array of positional arguments and a |
Collaborator
|
This is working fine on testing, as far as I can tell. |
bhardwajparth51
added a commit
to bhardwajparth51/openlibrary
that referenced
this pull request
Feb 17, 2026
…r/change-partials-url-format Migrate partials endpoint from querystring-based routing to path-based routing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate partials endpoint from querystring-based routing to path-based routing
This PR updates the partials endpoint so requests use a path segment for the component name, e.g.
/partials/AffiliateLinks.json, instead of the legacy querystring format/partials.json?_component=AffiliateLinks&....This is an API change, but we’re updating the only known consumer at the same time. Partials are intended for internal use (not public/external consumers), so the risk of breaking unknown clients should be low.
Why this change?
FastAPI requires routes and parameters to be defined more explicitly up front. Using a path-based component name keeps the FastAPI migration cleaner and avoids an increasingly messy set of query-parameter permutations in the current migration draft (#11773).
Technical
Testing
Screenshot
Stakeholders