Conversation
|
I think the team unanimously is leaning towards keeping these warnings and fixing them -- if you need, stage these for your AI agents :P |
|
I chatted with Ray, and I'd misunderstood the code change! This is only disabling the warnings from third-party dependencies . The warnings will still fire if they are coming from our code. This feels inline with most linters/etc tooling in other languages (eg JS). When we update to a new version of python, we should check the deprecation warnings. to see if we need to dump/update any dependencies. So I'm more inclined to merge, but open to feedback. Alternatively we could have all our dependencies updated so that there are no warnings and updates go through without issue. |
|
Update: |
|
Update, if we merge in the genshi and memcached upgrades then this will manually silence the warnings just from the packages that we don't have fixes. |
cdrini
left a comment
There was a problem hiding this comment.
Lgtm! This is much more targeted to specific deps and won't silence warnings we might care about!
* silence noisey pytest output * fix typo * show warnings also from scripts folder * only hide webob warnings * ignore pydantic warning coming from fastapi * ignore webpy warning * remove fastapi warning because it will be fixed in upgrade
Makes pytest less noise (to stop distracting the AI and other contributors).
It silencies the python warnings from our dependencies about them using older syntax.
I don't think we ever pay attention to these warnings anyway.
Before it looked like this:
Spoiler
After it looks like this:
Spoiler
Technical
asyncio_default_fixture_loop_scope = "function"All this does it set the value to the default that it will be set to in an upcoming release. Hence, quieting a warning about the change.
Testing
Screenshot
Stakeholders