Show Internet Archive identifier to librarians and admins for non-viewable books#11616
Merged
mekarpeles merged 4 commits intomasterfrom Feb 26, 2026
Merged
Conversation
Copilot
AI
changed the title
[WIP] Add archive.org link visibility for librarians
Show Internet Archive identifier to librarians and admins for non-viewable books
Dec 22, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restores visibility of Internet Archive identifiers to librarians and admins for non-viewable books, fixing a regression introduced in commit 278fd34 that hid these identifiers based solely on book availability.
Key Changes
- Modified the conditional check in the Edition Identifiers section to allow librarians and admins to see Internet Archive identifiers regardless of book viewability status
- Regular users continue to only see Internet Archive identifiers for viewable books
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
LGTM |
mekarpeles
force-pushed
the
copilot/show-archive-link-for-librarians
branch
2 times, most recently
from
ffc80af to
42c4394
Compare
- Modified view.html to display ocaid in Edition Identifiers section - Allows librarians and admins to see the archive.org link even when a book is not open or lendable - Maintains existing behavior for regular users Co-authored-by: mekarpeles <978325+mekarpeles@users.noreply.github.com>
- Use existing is_librarian variable instead of inline check - Cleaner condition that's easier to read - Maintains same functionality Co-authored-by: mekarpeles <978325+mekarpeles@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
mekarpeles
force-pushed
the
copilot/show-archive-link-for-librarians
branch
from
42c4394 to
860a508
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Technical
Librarians need to see archive.org identifiers for metadata verification and curation, even when books aren't open or lendable. Commit 278fd34 hid the
ocaidbased on availability, breaking this workflow.Modified
openlibrary/templates/type/edition/view.htmlline 454 to show Internet Archive identifier in Edition Identifiers section when user is librarian or admin:Reuses existing
is_librarianvariable. Regular users unchanged—still requires viewable book.Testing
ocaidthat is not open/lendableScreenshot
N/A - template-only change, requires local/staging environment with librarian credentials
Stakeholders
@mekarpeles
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.