X Tutup
Skip to content

refactor: Utilize new border radius LESS vars#11596

Merged
RayBB merged 10 commits intointernetarchive:masterfrom
lokesh:css-radius-part-2
Feb 14, 2026
Merged

refactor: Utilize new border radius LESS vars#11596
RayBB merged 10 commits intointernetarchive:masterfrom
lokesh:css-radius-part-2

Conversation

@lokesh
Copy link
Collaborator

@lokesh lokesh commented Dec 16, 2025

Issue # #11555

This PR is a follow-up to, and should be merged after:
#11557 - refactor: Define semantic border radius LESS vars

Technical

Utilizes new border-radius variables across codebase.

This creates one place in the codebase to manage border radii on site:
static/css/less/border-radius.less

Screenshot

With the standardization of border radius values, there will be slight visual changes. For example, buttons that previously had a border radius of 2px, 3px, or 5px -- are now standardized to use border-radius-button which is currently set to 4px.

Screenshots below are after the border-radius updates:

Screenshot 2025-12-16 at 2 38 40 PM Screenshot 2025-12-16 at 2 37 01 PM

Stakeholders

@mekarpeles @cdrini @jimchamp

@lokesh lokesh force-pushed the css-radius-part-2 branch from 1d71c06 to 27ace82 Compare January 6, 2026 23:17
@lokesh
Copy link
Collaborator Author

lokesh commented Jan 6, 2026

resolved merge conflict

@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label Jan 7, 2026
@lokesh lokesh added the Theme: Design Issues related to UI design, branding, etc. [managed] label Feb 4, 2026
@lokesh lokesh force-pushed the css-radius-part-2 branch from e99f50b to 27ace82 Compare February 4, 2026 22:25
@lokesh lokesh requested review from RayBB and removed request for RayBB February 13, 2026 19:20
@RayBB
Copy link
Collaborator

RayBB commented Feb 13, 2026

@lokesh looks like there's a merge conflict

Co-authored-by: Cursor <cursoragent@cursor.com>

# Conflicts:
#	static/css/page-design.less
@lokesh
Copy link
Collaborator Author

lokesh commented Feb 14, 2026

@RayBB fixed merged conflict, my mistake

@lokesh lokesh requested a review from RayBB February 14, 2026 00:04
Copy link
Collaborator

@RayBB RayBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried deploying this to testing, but the deploy failed for reasons unrelated to this PR. So instead, I tested locally in both desktop and mobile views.

As mentioned earlier, some of the numbers are changing (e.g., on the login page). At first I thought my setup was broken because I couldn’t see a difference. But after checking in DevTools, the underlying values were updated correctly. The change is just very very small.

Following Mek’s guidance: since this PR is low-risk and isn’t driving any major decisions, I think we’re good to merge.

Nice work on this one, @lokesh.

@RayBB RayBB merged commit cf8545c into internetarchive:master Feb 14, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs: Response Issues which require feedback from lead Theme: Design Issues related to UI design, branding, etc. [managed]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup