Move counter link higher up#11566
Merged
jimchamp merged 2 commits intointernetarchive:masterfrom Dec 18, 2025
Merged
Conversation
cdrini
added
the
Patch Deployed
Contributor
There was a problem hiding this comment.
Pull request overview
This PR relocates a hidden "Page Status" counter link from the footer navigation to the header navigation to ensure it appears earlier in the DOM order. This prevents other link discovery mechanisms (such as those used on search pages) from interfering with the counter link's functionality.
Key Changes
- Moved the hidden "Page Status" link from
nav_foot.htmltonav_head.html - Maintained all accessibility and styling attributes to keep the link invisible and non-interactive
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| openlibrary/templates/lib/nav_head.html | Added the hidden "Page Status" counter link within the logo component div, positioned early in the header DOM structure |
| openlibrary/templates/lib/nav_foot.html | Removed the "Page Status" counter link from the Help section footer |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jimchamp
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move counter link higher to avoid crawler link discovery on eg search pages getting caught before hitting it.
Technical
Testing
Screenshot
Stakeholders