Conversation
RayBB
changed the title
_load_legacy_wsgi now internally resolves its config file path instead of receiving it as an argument._load_legacy_wsgi now internally resolves its config file path instead of receiving it as an argument. fastapi
… path instead of receiving it as an argument.
cdrini
approved these changes
Dec 17, 2025
Collaborator
cdrini
left a comment
cdrini
left a comment
There was a problem hiding this comment.
Lgtm ; not testing, seems like a small refactor
mystic-06
pushed a commit
to mystic-06/openlibrary
that referenced
this pull request
Dec 24, 2025
… path instead of receiving it as an argument. fastapi (internetarchive#11484)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small changing that is being pulled out into it's own PR to simplify other PR reviews.
Has merge conflicts now. Will fix this up later.
Technical
Testing
Screenshot
Stakeholders