X Tutup
Skip to content

Add webp to supported formats listed on add cover page#11392

Merged
jimchamp merged 4 commits intointernetarchive:masterfrom
akramcodez:fix/covers-webp
Nov 4, 2025
Merged

Add webp to supported formats listed on add cover page#11392
jimchamp merged 4 commits intointernetarchive:masterfrom
akramcodez:fix/covers-webp

Conversation

@akramcodez
Copy link
Contributor

Fixes #11349

Description

Updated the cover upload prompt in openlibrary/openlibrary/templates/covers/add.html to include WebP since the form now accepts WebP images.

Before:

<label for="coverFile">$_("Choose a JPG, GIF or PNG on your computer")</label>

After:

<label for="coverFile">$_("Choose a JPG, GIF, PNG, or WebP on your computer")</label>

@akramcodez
Copy link
Contributor Author

PTAL @RayBB, thanks.

Copy link
Collaborator

@RayBB RayBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! @cdrini can you merge?

@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label Oct 30, 2025
@akramcodez akramcodez changed the title Fix/covers webp fix/covers webp Nov 2, 2025
Copilot AI review requested due to automatic review settings November 4, 2025 12:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the file upload label text to include WebP as a supported image format for cover uploads. The change ensures the user-facing text accurately reflects the formats already accepted by the file input element.

  • Updated the cover upload label to mention WebP as a supported format
  • Updated the corresponding translation string in the i18n messages file

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
openlibrary/templates/covers/add.html Updated the label text to include "WebP" alongside JPG, GIF, and PNG
openlibrary/i18n/messages.pot Updated the translation string to match the new label text

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Collaborator

@jimchamp jimchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @akramcodez!

@jimchamp jimchamp merged commit f7d7196 into internetarchive:master Nov 4, 2025
10 checks passed
@cdrini cdrini changed the title fix/covers webp Add webp to supported formats listed on add cover page Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs: Response Issues which require feedback from lead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Translation update needed for WebP

4 participants

X Tutup