Fix list queries erroring#11364
Merged
mekarpeles merged 1 commit intointernetarchive:masterfrom Oct 18, 2025
Merged
Conversation
cdrini
force-pushed
the
fix/list-queries
branch
from
a551945 to
e7050df
Compare
cdrini
force-pushed
the
fix/list-queries
branch
from
e7050df to
50227f5
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes errors occurring in list queries by improving the query parsing and parameter handling. The fix ensures proper extraction of list keys from query strings and handles null offset/limit values gracefully.
Key Changes:
- Added type hints and default value handling for offset/limit parameters to prevent null reference errors
- Replaced substring check with regex matching to properly extract and validate list keys from query strings
- Used regex substitution to replace only the list key portion of the query while preserving other query parameters
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+1015
to
+1019
| q = re.sub( | ||
| r'^(/people/[^/]+)?/lists/OL\d+L', | ||
| f"key:({' OR '.join(book_keys)})" if book_keys else "-key:*", | ||
| q, | ||
| ) |
There was a problem hiding this comment.
The regex pattern r'^(/people/[^/]+)?/lists/OL\\d+L' is duplicated from line 1008. Consider extracting this pattern into a named constant (e.g., LIST_KEY_PATTERN) to improve maintainability and ensure consistency if the pattern needs to be updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11365
Technical
Testing
https://openlibrary.org/collections/the_haunted_library no longer throws errors -- https://testing.openlibrary.org/collections/the_haunted_library
Screenshot
Stakeholders