Conversation
Removing unsupported identifier from the configuration.
There was a problem hiding this comment.
Pull Request Overview
This PR removes an unsupported "Anna's Archive" identifier configuration from the edition identifiers list, reverting a previously added identifier that was determined to be unsupported.
- Removes the "annas_archive" identifier entry from the identifiers configuration
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
mekarpeles
added
the
Priority: 1
|
Proof of concept of removing an unsupported identifier import web
import infogami
import os
from openlibrary.config import load_config
path = '/olsystem/etc/openlibrary.yml'
load_config(path)
infogami._setup()
from infogami import config
from openlibrary.accounts import RunAs
web.ctx.ip = web.ctx.ip or '127.0.0.1'
def rmids(limit=100, id_type="foo"):
editions = web.ctx.site.things({"type": "/type/edition", f"identifiers.{id_type}~": "*", 'limit': limit})
records = [r.dict() for r in web.ctx.site.get_many(editions)]
for r in records:
r['identifiers'].pop(id_type)
with RunAs('ImportBot'):
web.ctx.site.save_many(records, comment="Removing unsupported identifier") |
Why was this removed/unsupported? |
How was this an unsupported identifier when it was actively being used up until it was removed? |
Removing unsupported identifier from the configuration.
Reverts adding an unsupported identifier, as per discussion w/ @seabelis
Technical
Testing
Screenshot
Stakeholders