Fix Repeat(<value>).equals(undefined) incorrectly returning true#1994
Merged
jdeniau merged 2 commits intoimmutable-js:mainfrom May 10, 2024
Merged
Fix Repeat(<value>).equals(undefined) incorrectly returning true#1994jdeniau merged 2 commits intoimmutable-js:mainfrom
jdeniau merged 2 commits intoimmutable-js:mainfrom
Conversation
jdeniau
approved these changes
May 10, 2024
Member
jdeniau
left a comment
jdeniau
left a comment
There was a problem hiding this comment.
Hi!
Thanks for this fix.
Would you mind adding a test that did previously failed and now works?
Thanks
butchler
force-pushed
the
fix-repeat-equals
branch
from
fbd3436 to
32f5757
Compare
Contributor
Author
I pushed a commit that adds a test just now. |
Member
|
Thanks, I did merge but I'm not at home actually. I will push a fix probably next week and on the 5.x branch |
Member
|
This has been released in v4.3.6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems like there was a mistake in this old commit, when
deepEqualwas switched from an inherited method to a helper function: 79e903b#diff-3ef08c64dab5fc92ebb8aecee330d5e7ae6cc8651f95aab2968b392c228dc606R103Note that this only happens when calling the
.equalsmethod directly.Immutable.is(Immutable.Repeat(<value>), undefined)properly returns false, so this is a very minor issue that's unlikely to happen in practice. I only noticed this because I was looking at the immutable-js source code.