Issue #286: Added main method in Abstract Factory Example#291
Merged
iluwatar merged 1 commit intoiluwatar:masterfrom Nov 14, 2015
Merged
Issue #286: Added main method in Abstract Factory Example#291iluwatar merged 1 commit intoiluwatar:masterfrom
iluwatar merged 1 commit intoiluwatar:masterfrom
Conversation
Owner
|
I agree with your refactoring proposal. I will accept if you make another PR for that. |
Owner
|
This looks good. Thank you for the help! |
iluwatar
added a commit
that referenced
this pull request
Nov 14, 2015
Issue #286: Added main method in Abstract Factory Example
Contributor
Author
|
Thank you for accepting! Witch tool do you use for making class diagrams? Is it free? |
Owner
|
It is described in the developer wiki, here https://github.com/iluwatar/java-design-patterns/wiki/01.-How-to-contribute |
pratigya0
pushed a commit
to pratigya0/java-design-patterns
that referenced
this pull request
Aug 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it would be better to rename the App class to something like: Factory Producer. And the main method should be in the real App file as unique method. What do you think?