Conversation
|
I will add the Junits, but I would like to now whether the design is okay |
|
The initial code looks ok. The branch is not up to date with master. Please catch up the branch and implement the missing items in the following checklist.
|
|
I am also reviewing it. |
|
Don't know what caused the build break. I have updated the files with comments and Junits. Locally my build passed. |
|
Use version number 1.7.0 in |
Fixed Reference to Parent POM
|
@iluwatar Thanks. Understood. I had already done a build with the parent POM at 1.6.0. So when I did a local build yesterday, it passed since my local maven repo had a reference to 1.6.0. I have corrected the reference to the parent POM. Can you review the code? |
monostate/index.md
Outdated
|
@npathai Any additional comments? |
|
@iluwatar I noticed the pom error was about to commit the changes with one minor modification. Which would improve Junit coverage. Committed the changes. Please do a review once you have time. |
|
@iluwatar Had been away for some days. Will review it today. |
|
Good work. Looks good to go. Thanks for your contribution. |
|
@npathai Thanks...Will start working on the leader follower pattern |
Implemented the pattern. Created a custom load balancer. Will add java comments.
The Documentation and Class Diagram is present. Please let me know if any other things needs to be done.