@hannespernpeintner Did you get the lazy meaning? You can try implementing if you want. You know it never hurts to have something extra.

Yes i got it. I'll implement a lazy version as well :)

Okay, took me more time than expected because the lazy implementation is more complex than the eager one - but I added a lazy implementation and extracted an interface.

Would be nice to hear your thoughts :)

@hannespernpeintner I have been a bit busy lately. Will be sending initial comments soon.

Hey, what about your feedback? :)

@hannespernpeintner Give me a day or two :)

@hannespernpeintner I am done with initial review. Awaiting your response.

Thank you very much for your excellent feedback. I corrected everything you stated (I think) - that's the reason I passed on replying to some of your comments. Some points probably need further discussion, so I replied to them directly.

Summary of review:

• Logic: I have some doubts about implementation of last(count) in both versions. Will be giving feedback on that after trying something myself.
• Suggestion: It is difficult to review the changes undertaken so I suggest you to leave comments on the points incorporated as well. Something like Done! will be quite helpful.
• Suggestion: We can document that SimpleFluentIterable is too costly to be utilized in real applications.
• Doubt: Do we need forEach() method in our FluentIterables as they already extend Iterable and there is default implementation in interface.

• Thank you for your effort. What are your doubts about: performance, if they're necessary, if they are wrong?
• I added a comment for all comments of yours.
• Should this be added to the class documentation, or what's the best place to add it?
• My first implementation allowed to embed it as a non-terminating operation in a fluent usage, but later, I changed it. Now I removed it, we don't need it as it is now.

Thank you so far, I'm looking forward to your next comments :)

• Yes about performance.
• Great.
• Yes class documentation would be perfect!
• Great.

I am moving towards final review. Will provide comments soon.

I ammended documentation changes. Nothing left to do currently, thank you for your help, I'm waiting for further responses :)

LGTM you can move towards other tasks to complete this PR.

Tasks:

• Implementation
• Documentation
• Code formatting according to Google Java guide
• Verify coverage
• Create class diagram
• Provide website content - visit wiki for steps
• * We can have better tests for this design pattern. But that can be other PR.
• Get pom.xml version info verified by @iluwatar

The latest commit should complete the PR. However, I can't find a guideline to your code coverage rules. Currently, the coverage is 91.5%.

@hannespernpeintner Its good enough 👍 I will bring this point up on chat room and soon we will add the guideline on coverage ratio.

@hannespernpeintner You have not created an index.md file as suggested in How to contribute section. Your branch is far too outdated, you need to merge the changes from iluwatar/master into your fork/master branch. We have removed the patterns from README and created website pages. So you need to incorporate those changes.

Ah, this totally bypassed me. I rebased and added the description. Anything else (the ci seems to fail)? :)

@hannespernpeintner Include Iterable in UML diagram. Also add association links between the classes in diagram such as App uses FluentIterable.

Included. I considered some relationships as unimportant, so I left them out. Everything pushed, what else? :)

@hannespernpeintner I have commented on a few last changes. Once done we can merge it 🎉

I corrected them, kindly ask you to have the last look on it :)