X Tutup
Skip to content

Fixing License issue in MVVM pattern#1701

Merged
iluwatar merged 7 commits intoiluwatar:masterfrom
jinishavora:master
Jun 8, 2021
Merged

Fixing License issue in MVVM pattern#1701
iluwatar merged 7 commits intoiluwatar:masterfrom
jinishavora:master

Conversation

@jinishavora
Copy link
Copy Markdown
Contributor

@jinishavora jinishavora commented Apr 10, 2021 •
edited
Loading

Have added LGPL and GPL license txt files in root dir.
Have updated LICENSE.md file with added GPL license, should I add LGPL License as well, I thought they can be used interchangeably, but I can be wrong???
Have updated the parent pom such that it will update all the source files including updating all src files within the modules with the license as mentioned in LICENSE.md
@iluwatar @ohbus Please review my above comments and the code changes and let me know what are your thoughts.

@ohbus ohbus self-assigned this Apr 11, 2021
@ohbus ohbus requested a review from iluwatar April 12, 2021 05:19
@iluwatar iluwatar self-assigned this Apr 18, 2021
@iluwatar
Copy link
Copy Markdown
Owner

iluwatar commented Apr 18, 2021

Relates to issue #1690

iluwatar
iluwatar requested changes Apr 18, 2021
View reviewed changes
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 21, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ohbus ohbus linked an issue Apr 25, 2021 that may be closed by this pull request
License issue in MVVM pattern #1690
Closed
2 tasks
ohbus
ohbus reviewed Apr 25, 2021
View reviewed changes
ohbus
ohbus reviewed May 22, 2021
View reviewed changes
@jinishavora
Copy link
Copy Markdown
Contributor Author

jinishavora commented May 27, 2021

@ohbus @iluwatar Please review the changes and let me know if its ok ?

@ohbus
Copy link
Copy Markdown
Contributor

ohbus commented May 28, 2021

@ohbus @iluwatar Please review the changes and let me know if its ok ?

Let me check.

ohbus
ohbus reviewed May 28, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@ohbus ohbus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we adding the GPL text?

Could out just point it back to me. I just lost track if we have already discussed it earlier somewhere else.

@jinishavora
Copy link
Copy Markdown
Contributor Author

jinishavora commented May 28, 2021

Why are we adding the GPL text?

Could out just point it back to me. I just lost track if we have already discussed it earlier somewhere else.

I added it with lgpl, not sure if we needed both, should I get rid of the gpl one?

@ohbus
Copy link
Copy Markdown
Contributor

ohbus commented May 28, 2021

Why are we adding the GPL text?
Could out just point it back to me. I just lost track if we have already discussed it earlier somewhere else.

I added it with lgpl, not sure if we needed both, should I get rid of the gpl one?

I believe we should discard GPL text

@jinishavora
Copy link
Copy Markdown
Contributor Author

jinishavora commented May 28, 2021

@ohbus, check latest changes and let me know

ohbus
ohbus previously approved these changes May 28, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@ohbus ohbus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes and updates!

@jinishavora
Copy link
Copy Markdown
Contributor Author

jinishavora commented May 28, 2021

@ohbus @iluwatar I hope this one is done? let me know if I have missed something..

@iluwatar
Copy link
Copy Markdown
Owner

iluwatar commented Jun 4, 2021

A couple of things:

@jinishavora
Copy link
Copy Markdown
Contributor Author

jinishavora commented Jun 4, 2021

A couple of things:

@iluwatar I had the gpl text, @ohbus suggested I remove it, can you please confirm if the file I removed is the one we need back or do we need something else?

@iluwatar
Copy link
Copy Markdown
Owner

iluwatar commented Jun 5, 2021

@jinishavora yes, looks correct to me. Please restore it and we can merge.

@ohbus
Copy link
Copy Markdown
Contributor

ohbus commented Jun 7, 2021

A couple of things:

@jinishavora yes, looks correct to me. Please restore it and we can merge.

Thank you so much @iluwatar for the suggestions. Really helped a lot.

@ohbus
Copy link
Copy Markdown
Contributor

ohbus commented Jun 7, 2021

A couple of things:

@iluwatar I had the gpl text, @ohbus suggested I remove it, can you please confirm if the file I removed is the one we need back or do we need something else?

Really sorry for the trouble @jinishavora, I have overlooked it.

Please make the necessary amendments to the PR to get it accepted.

@jinishavora
Copy link
Copy Markdown
Contributor Author

jinishavora commented Jun 7, 2021

A couple of things:

@iluwatar I had the gpl text, @ohbus suggested I remove it, can you please confirm if the file I removed is the one we need back or do we need something else?

Really sorry for the trouble @jinishavora, I have overlooked it.

Please make the necessary amendments to the PR to get it accepted.

No worries @ohbus, file committed, please review.

@jinishavora
Copy link
Copy Markdown
Contributor Author

jinishavora commented Jun 7, 2021

@jinishavora yes, looks correct to me. Please restore it and we can merge.

@iluwatar done, please review.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jun 7, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

ohbus
ohbus approved these changes Jun 7, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@ohbus ohbus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iluwatar iluwatar added this to the 1.25.0 milestone Jun 8, 2021
@iluwatar iluwatar merged commit bbdff14 into iluwatar:master Jun 8, 2021
@iluwatar
Copy link
Copy Markdown
Owner

iluwatar commented Jun 8, 2021

Thank you for handling this issue @jinishavora, it wasn't the easiest to work with. Your contribution is much appreciated!

@jinishavora
Copy link
Copy Markdown
Contributor Author

jinishavora commented Jun 8, 2021

Thank you for handling this issue @jinishavora, it wasn't the easiest to work with. Your contribution is much appreciated!

Thanks @iluwatar! Appreciate your kind words.

RobbiNespu pushed a commit to RobbiNespu/java-design-patterns that referenced this pull request Mar 1, 2022
@jinishavora @RobbiNespu
Fix: Fixing License issue in MVVM pattern (iluwatar#1701)
22f705b 
* Fixing License issue in MVVM pattern

* Updating LICENSE.md

* Updating pom.xml

* License header update to MVVM module only.

* Updating pom and removing gpl txt

* Adding gpl txt file

Co-authored-by: Jinisha <Jinisha@LAPTOP-VG38PNMC.fios-router.home>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iluwatar iluwatar iluwatar approved these changes

+1 more reviewer

@ohbus ohbus ohbus approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@iluwatar iluwatar

@ohbus ohbus

Labels

status: under review

Projects

None yet

Milestone

1.25.0

Development

Successfully merging this pull request may close these issues.

License issue in MVVM pattern

3 participants

@jinishavora @iluwatar @ohbus
X Tutup