Fix error message in gguf_quantizer.py#13236
Open
eliemichel wants to merge 1 commit intohuggingface:mainfrom
Open
Fix error message in gguf_quantizer.py#13236eliemichel wants to merge 1 commit intohuggingface:mainfrom
eliemichel wants to merge 1 commit intohuggingface:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I believe that the error message was wrong, since the shapes mentionned did not match the test trigering the error. I think that there is also an ambiguity on what is meant by "quantized" shape: the value returned by the function
_quant_shape_from_byte_shape()is used indequantize_gguf_tensor()as the shape of the dequantized tensor, but the name of_quant_shape_from_byte_shape()suggests that what it returns is the shape of the quantized tensor. I found it safer to remove the term "quantized" from the error message.Before submitting
Who can review?
@stevhliu @sayakpaul @DN6