Open
Conversation
lawrence-cj
force-pushed
the
sana-video-ltx2vae
branch
from
5db0b20 to
c03b739
Compare
Member
|
@lawrence-cj thanks for the PR! Could you also provide some sample outputs? |
sayakpaul
reviewed
Mar 10, 2026
Comment on lines
+226
to
+244
| if getattr(self, "vae", None): | ||
| if hasattr(self.vae.config, "scale_factor_temporal"): | ||
| self.vae_scale_factor_temporal = self.vae.config.scale_factor_temporal | ||
| elif hasattr(self.vae.config, "temporal_compression_ratio"): | ||
| # LTX2 VAE uses temporal_compression_ratio | ||
| self.vae_scale_factor_temporal = self.vae.config.temporal_compression_ratio | ||
| else: | ||
| self.vae_scale_factor_temporal = getattr(self.vae, "temporal_compression_ratio", 4) | ||
|
|
||
| if hasattr(self.vae.config, "scale_factor_spatial"): | ||
| self.vae_scale_factor_spatial = self.vae.config.scale_factor_spatial | ||
| elif hasattr(self.vae.config, "spatial_compression_ratio"): | ||
| # LTX2 VAE uses spatial_compression_ratio | ||
| self.vae_scale_factor_spatial = self.vae.config.spatial_compression_ratio | ||
| else: | ||
| self.vae_scale_factor_spatial = getattr(self.vae, "spatial_compression_ratio", 8) | ||
| else: | ||
| self.vae_scale_factor_temporal = 4 | ||
| self.vae_scale_factor_spatial = 8 |
Member
There was a problem hiding this comment.
Hmm, should this be conditioned on the class type of the VAE being used?
sayakpaul
reviewed
Mar 10, 2026
Member
sayakpaul
left a comment
sayakpaul
left a comment
There was a problem hiding this comment.
Thanks, I just left one comment. But it looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds LTX-VAE support for SANA-Video.
Cc: @dg845 @sayakpaul