tree-wide: use curl --fail

keszybz · keszybz · commit 79758570798d · 2021-01-15T18:35:02.000+01:00
curl will save the 404 response page (or another error) if the page
download fails, which we never want. Let it error out instead.
diff --git a/src/basic/linux/update.sh b/src/basic/linux/update.sh
@@ -4,9 +4,9 @@ set -eu
 
 for i in *.h */*.h; do
     if [[ $i == 'loadavg.h' ]]; then
-        curl https://raw.githubusercontent.com/torvalds/linux/master/include/linux/sched/$i -o $i
+        curl --fail https://raw.githubusercontent.com/torvalds/linux/master/include/linux/sched/$i -o $i
     else
-        curl https://raw.githubusercontent.com/torvalds/linux/master/include/uapi/linux/$i -o $i
+        curl --fail https://raw.githubusercontent.com/torvalds/linux/master/include/uapi/linux/$i -o $i
     fi
 
     sed -i -e 's/__user //g' -e '/^#include <linux\/compiler.h>/ d' $i
diff --git a/tools/autosuspend-update.sh b/tools/autosuspend-update.sh
@@ -3,5 +3,5 @@ set -eu
 
 cd "$1"
 
-(curl -L 'https://chromium.googlesource.com/chromiumos/platform2/+/master/power_manager/udev/gen_autosuspend_rules.py?format=TEXT'; echo) \
+(curl --fail -L 'https://chromium.googlesource.com/chromiumos/platform2/+/master/power_manager/udev/gen_autosuspend_rules.py?format=TEXT'; echo) \
     | base64 -d > gen_autosuspend_rules.py
diff --git a/tools/hwdb-update.sh b/tools/hwdb-update.sh
@@ -15,13 +15,13 @@ if [ "${2:-}" != "-n" ]; then (
     [ -z "$permissive" ] || set +e
     set -x
 
-    curl -L -o usb.ids 'http://www.linux-usb.org/usb.ids'
-    curl -L -o pci.ids 'http://pci-ids.ucw.cz/v2.2/pci.ids'
-    curl -L -o ma-large.txt 'http://standards-oui.ieee.org/oui/oui.txt'
-    curl -L -o ma-medium.txt 'http://standards-oui.ieee.org/oui28/mam.txt'
-    curl -L -o ma-small.txt 'http://standards-oui.ieee.org/oui36/oui36.txt'
-    curl -L -o pnp_id_registry.html 'https://uefi.org/uefi-pnp-export'
-    curl -L -o acpi_id_registry.html 'https://uefi.org/uefi-acpi-export'
+    curl --fail -L -o usb.ids 'http://www.linux-usb.org/usb.ids'
+    curl --fail -L -o pci.ids 'http://pci-ids.ucw.cz/v2.2/pci.ids'
+    curl --fail -L -o ma-large.txt 'http://standards-oui.ieee.org/oui/oui.txt'
+    curl --fail -L -o ma-medium.txt 'http://standards-oui.ieee.org/oui28/mam.txt'
+    curl --fail -L -o ma-small.txt 'http://standards-oui.ieee.org/oui36/oui36.txt'
+    curl --fail -L -o pnp_id_registry.html 'https://uefi.org/uefi-pnp-export'
+    curl --fail -L -o acpi_id_registry.html 'https://uefi.org/uefi-acpi-export'
 ) fi
 
 set -x
diff --git a/tools/syscall-table-update.sh b/tools/syscall-table-update.sh
@@ -3,8 +3,8 @@ set -eu
 
 cd "$1" && shift
 
-curl -L -o syscall-names.text 'https://raw.githubusercontent.com/hrw/syscalls-table/master/syscall-names.text'
+curl --fail -L -o syscall-names.text 'https://raw.githubusercontent.com/hrw/syscalls-table/master/syscall-names.text'
 
 for arch in "$@"; do
-    curl -L -o syscalls-$arch "https://raw.githubusercontent.com/hrw/syscalls-table/master/tables/syscalls-$arch"
+    curl --fail -L -o syscalls-$arch "https://raw.githubusercontent.com/hrw/syscalls-table/master/tables/syscalls-$arch"
 done
