X Tutup
Skip to content

Commit 015fa29

Browse files
committed
Revert "Revert "Makefile: rm go 1.13 workaround""
This reverts commit 1a659bc, essentially reinstating commit d0cbef5. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
1 parent 4071c3c commit 015fa29

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

Makefile

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,20 +13,16 @@ BUILDTAGS ?= seccomp
1313
COMMIT ?= $(shell git describe --dirty --long --always)
1414
VERSION := $(shell cat ./VERSION)
1515

16-
# TODO: rm -mod=vendor once go 1.13 is unsupported
17-
ifneq ($(GO111MODULE),off)
18-
MOD_VENDOR := "-mod=vendor"
19-
endif
2016
ifeq ($(shell $(GO) env GOOS),linux)
2117
ifeq (,$(filter $(shell $(GO) env GOARCH),mips mipsle mips64 mips64le ppc64))
2218
ifeq (,$(findstring -race,$(EXTRA_FLAGS)))
2319
GO_BUILDMODE := "-buildmode=pie"
2420
endif
2521
endif
2622
endif
27-
GO_BUILD := $(GO) build -trimpath $(MOD_VENDOR) $(GO_BUILDMODE) $(EXTRA_FLAGS) -tags "$(BUILDTAGS)" \
23+
GO_BUILD := $(GO) build -trimpath $(GO_BUILDMODE) $(EXTRA_FLAGS) -tags "$(BUILDTAGS)" \
2824
-ldflags "-X main.gitCommit=$(COMMIT) -X main.version=$(VERSION) $(EXTRA_LDFLAGS)"
29-
GO_BUILD_STATIC := CGO_ENABLED=1 $(GO) build -trimpath $(MOD_VENDOR) $(EXTRA_FLAGS) -tags "$(BUILDTAGS) netgo osusergo" \
25+
GO_BUILD_STATIC := CGO_ENABLED=1 $(GO) build -trimpath $(EXTRA_FLAGS) -tags "$(BUILDTAGS) netgo osusergo" \
3026
-ldflags "-w -extldflags -static -X main.gitCommit=$(COMMIT) -X main.version=$(VERSION) $(EXTRA_LDFLAGS)"
3127

3228
.DEFAULT: runc
@@ -73,7 +69,7 @@ unittest: runcimage
7369
$(RUNC_IMAGE) make localunittest TESTFLAGS=$(TESTFLAGS)
7470

7571
localunittest: all
76-
$(GO) test $(MOD_VENDOR) -timeout 3m -tags "$(BUILDTAGS)" $(TESTFLAGS) -v ./...
72+
$(GO) test -timeout 3m -tags "$(BUILDTAGS)" $(TESTFLAGS) -v ./...
7773

7874
integration: runcimage
7975
$(CONTAINER_ENGINE) run $(CONTAINER_ENGINE_RUN_FLAGS) \

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ A third party security audit was performed by Cure53, you can see the full repor
2424
## Building
2525

2626
`runc` currently supports the Linux platform with various architecture support.
27-
It must be built with Go version 1.13 or higher.
27+
It must be built with Go version 1.14 or higher.
2828

2929
In order to enable seccomp support you will need to install `libseccomp` on your platform.
3030
> e.g. `libseccomp-devel` for CentOS, or `libseccomp-dev` for Ubuntu

0 commit comments

Comments
 (0)
X Tutup