FIX docker-archive-public#2941 Wait for Docker after a restart

dgageot · dgageot · commit 1bc6cdd3570e · 2016-01-27T09:35:47.000+01:00
Signed-off-by: David Gageot &lt;david@gageot.net&gt;
diff --git a/libmachine/host/host.go b/libmachine/host/host.go
@@ -104,25 +104,24 @@ func (h *Host) runActionForState(action func() error, desiredState state.State)
 	return mcnutils.WaitFor(drivers.MachineInState(h.Driver, desiredState))
 }
 
-func (h *Host) Start() error {
-	log.Infof("Starting %q...", h.Name)
-	if err := h.runActionForState(h.Driver.Start, state.Running); err != nil {
-		return err
-	}
-
-	log.Infof("Machine %q was started.", h.Name)
-
+func (h *Host) WaitForDocker() error {
 	provisioner, err := provision.DetectProvisioner(h.Driver)
 	if err != nil {
 		return err
 	}
 
-	// TODO: Migrate away from using hardcoded daemon port.
-	if err := provision.WaitForDocker(provisioner, engine.DefaultPort); err != nil {
+	return provision.WaitForDocker(provisioner, engine.DefaultPort)
+}
+
+func (h *Host) Start() error {
+	log.Infof("Starting %q...", h.Name)
+	if err := h.runActionForState(h.Driver.Start, state.Running); err != nil {
 		return err
 	}
 
-	return nil
+	log.Infof("Machine %q was started.", h.Name)
+
+	return h.WaitForDocker()
 }
 
 func (h *Host) Stop() error {
@@ -148,17 +147,19 @@ func (h *Host) Kill() error {
 func (h *Host) Restart() error {
 	log.Infof("Restarting %q...", h.Name)
 	if drivers.MachineInState(h.Driver, state.Stopped)() {
-		return h.Start()
-	}
-
-	if drivers.MachineInState(h.Driver, state.Running)() {
+		if err := h.Start(); err != nil {
+			return err
+		}
+	} else if drivers.MachineInState(h.Driver, state.Running)() {
 		if err := h.Driver.Restart(); err != nil {
 			return err
 		}
-		return mcnutils.WaitFor(drivers.MachineInState(h.Driver, state.Running))
+		if err := mcnutils.WaitFor(drivers.MachineInState(h.Driver, state.Running)); err != nil {
+			return err
+		}
 	}
 
-	return nil
+	return h.WaitForDocker()
 }
 
 func (h *Host) Upgrade() error {
