X Tutup
Skip to content

Commit 319c285

Browse files
codebytereMarshallOfSound
authored andcommitted
chore: move ts-smoke tests to core (electron#16930)
* chore: move ts smoke tests to core * fix: fix paths for tsconfig / ts-smoke runner * update ts-defs version * do not lintr
1 parent 95214fc commit 319c285

File tree

7 files changed

+1470
-3
lines changed

7 files changed

+1470
-3
lines changed

docs/api/global-shortcut.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,8 @@ The `globalShortcut` module has the following methods:
4747
* `accelerator` [Accelerator](accelerator.md)
4848
* `callback` Function
4949

50+
Returns `Boolean` - Whether or not the shortcut was registered successfully.
51+
5052
Registers a global shortcut of `accelerator`. The `callback` is called when
5153
the registered shortcut is pressed by the user.
5254

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"dotenv-safe": "^4.0.4",
1616
"dugite": "^1.45.0",
1717
"electron-docs-linter": "^2.4.0",
18-
"electron-typescript-definitions": "^6.0.0",
18+
"electron-typescript-definitions": "^7.0.0",
1919
"eslint": "^5.13.0",
2020
"eslint-config-standard": "^12.0.0",
2121
"eslint-plugin-mocha": "^5.2.0",
@@ -57,7 +57,7 @@
5757
"lint:docs-relative-links": "python ./script/check-relative-doc-links.py",
5858
"lint:js-in-markdown": "standard-markdown docs",
5959
"create-api-json": "electron-docs-linter docs --outfile=electron-api.json",
60-
"create-typescript-definitions": "npm run create-api-json && electron-typescript-definitions --in=electron-api.json --out=electron.d.ts",
60+
"create-typescript-definitions": "npm run create-api-json && electron-typescript-definitions --in=electron-api.json --out=electron.d.ts && node spec/ts-smoke/runner.js",
6161
"gn-typescript-definitions": "npm run create-typescript-definitions && cp electron.d.ts",
6262
"preinstall": "node -e 'process.exit(0)'",
6363
"precommit": "lint-staged",

script/lint.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,10 @@ const BLACKLIST = new Set([
2929
['atom', 'common', 'common_message_generator.cc'],
3030
['atom', 'common', 'common_message_generator.h'],
3131
['atom', 'common', 'node_includes.h'],
32-
['spec', 'static', 'jquery-2.0.3.min.js']
32+
['spec', 'static', 'jquery-2.0.3.min.js'],
33+
['spec', 'ts-smoke', 'electron', 'main.ts'],
34+
['spec', 'ts-smoke', 'electron', 'renderer.ts'],
35+
['spec', 'ts-smoke', 'runner.js']
3336
].map(tokens => path.join(SOURCE_ROOT, ...tokens)))
3437

3538
function spawnAndCheckExitCode (cmd, args, opts) {

0 commit comments

Comments
 (0)
X Tutup