Add exec id check on client

crosbymichael · crosbymichael · commit cd4e8ba4485b · 2017-07-12T10:41:04.000-07:00
Signed-off-by: Michael Crosby &lt;crosbymichael@gmail.com&gt;
diff --git a/container.go b/container.go
@@ -23,6 +23,7 @@ var (
 	ErrNoRunningTask     = errors.New("no running task")
 	ErrDeleteRunningTask = errors.New("cannot delete container with running task")
 	ErrProcessExited     = errors.New("process already exited")
+	ErrNoExecID          = errors.New("exec id must be provided")
 )
 
 type DeleteOpts func(context.Context, *Client, containers.Container) error
diff --git a/task.go b/task.go
@@ -191,6 +191,9 @@ func (t *task) Delete(ctx context.Context) (uint32, error) {
 }
 
 func (t *task) Exec(ctx context.Context, id string, spec *specs.Process, ioCreate IOCreation) (Process, error) {
+	if id == "" {
+		return nil, ErrNoExecID
+	}
 	i, err := ioCreate()
 	if err != nil {
 		return nil, err

Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,7 @@ var (`
`23`	`23`	`ErrNoRunningTask = errors.New("no running task")`
`24`	`24`	`ErrDeleteRunningTask = errors.New("cannot delete container with running task")`
`25`	`25`	`ErrProcessExited = errors.New("process already exited")`
	`26`	`+ ErrNoExecID = errors.New("exec id must be provided")`
`26`	`27`	`)`
`27`	`28`
`28`	`29`	`type DeleteOpts func(context.Context, *Client, containers.Container) error`
Original file line number	Diff line number	Diff line change
`@@ -191,6 +191,9 @@ func (t *task) Delete(ctx context.Context) (uint32, error) {`
`191`	`191`	`}`
`192`	`192`
`193`	`193`	`func (t task) Exec(ctx context.Context, id string, spec specs.Process, ioCreate IOCreation) (Process, error) {`
	`194`	`+ if id == "" {`
	`195`	`+ return nil, ErrNoExecID`
	`196`	`+ }`
`194`	`197`	`i, err := ioCreate()`
`195`	`198`	`if err != nil {`
`196`	`199`	`return nil, err`