Fix truncateLabels for empty values

mislav · mislav · commit feec114bb6f1 · 2020-11-11T15:29:40.000+01:00
diff --git a/pkg/cmd/issue/shared/display.go b/pkg/cmd/issue/shared/display.go
@@ -49,6 +49,9 @@ func PrintIssues(io *iostreams.IOStreams, prefix string, totalCount int, issues
 }
 
 func truncateLabels(w int, t string) string {
+	if len(t) < 2 {
+		return t
+	}
 	truncated := text.Truncate(w-2, t[1:len(t)-1])
 	return fmt.Sprintf("(%s)", truncated)
 }
diff --git a/pkg/cmd/issue/shared/display_test.go b/pkg/cmd/issue/shared/display_test.go
@@ -8,4 +8,8 @@ func Test_truncateLabels(t *testing.T) {
 	if got != expected {
 		t.Errorf("expected %q, got %q", expected, got)
 	}
+
+	if truncateLabels(10, "") != "" {
+		t.Error("blank value error")
+	}
 }

Original file line number	Diff line number	Diff line change
`@@ -49,6 +49,9 @@ func PrintIssues(io *iostreams.IOStreams, prefix string, totalCount int, issues`
`49`	`49`	`}`
`50`	`50`
`51`	`51`	`func truncateLabels(w int, t string) string {`
	`52`	`+ if len(t) < 2 {`
	`53`	`+ return t`
	`54`	`+ }`
`52`	`55`	`truncated := text.Truncate(w-2, t[1:len(t)-1])`
`53`	`56`	`return fmt.Sprintf("(%s)", truncated)`
`54`	`57`	`}`
Original file line number	Diff line number	Diff line change
`@@ -8,4 +8,8 @@ func Test_truncateLabels(t *testing.T) {`
`8`	`8`	`if got != expected {`
`9`	`9`	`t.Errorf("expected %q, got %q", expected, got)`
`10`	`10`	`}`
	`11`	`+`
	`12`	`+ if truncateLabels(10, "") != "" {`
	`13`	`+ t.Error("blank value error")`
	`14`	`+ }`
`11`	`15`	`}`