Consistently print browsed URL across commands

mislav · mislav · commit fda9659e4a51 · 2020-09-09T17:02:02.000+02:00
diff --git a/pkg/cmd/issue/view/view.go b/pkg/cmd/issue/view/view.go
@@ -83,7 +83,9 @@ func viewRun(opts *ViewOptions) error {
 	openURL := issue.URL
 
 	if opts.WebMode {
-		fmt.Fprintf(opts.IO.ErrOut, "Opening %s in your browser.\n", openURL)
+		if opts.IO.IsStdoutTTY() {
+			fmt.Fprintf(opts.IO.ErrOut, "Opening %s in your browser.\n", utils.DisplayURL(openURL))
+		}
 		return utils.OpenInBrowser(openURL)
 	}
 	if opts.IO.IsStdoutTTY() {
diff --git a/pkg/cmd/pr/view/view.go b/pkg/cmd/pr/view/view.go
@@ -94,7 +94,7 @@ func viewRun(opts *ViewOptions) error {
 
 	if opts.BrowserMode {
 		if connectedToTerminal {
-			fmt.Fprintf(opts.IO.ErrOut, "Opening %s in your browser.\n", openURL)
+			fmt.Fprintf(opts.IO.ErrOut, "Opening %s in your browser.\n", utils.DisplayURL(openURL))
 		}
 		return utils.OpenInBrowser(openURL)
 	}

Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,7 @@ func viewRun(opts *ViewOptions) error {`
`94`	`94`
`95`	`95`	`if opts.BrowserMode {`
`96`	`96`	`if connectedToTerminal {`
`97`		`- fmt.Fprintf(opts.IO.ErrOut, "Opening %s in your browser.\n", openURL)`
	`97`	`+ fmt.Fprintf(opts.IO.ErrOut, "Opening %s in your browser.\n", utils.DisplayURL(openURL))`
`98`	`98`	`}`
`99`	`99`	`return utils.OpenInBrowser(openURL)`
`100`	`100`	`}`