fix: respect GH_FORCE_TTY when running gh pr view

callumacrae · callumacrae · commit f7ef503051ff · 2022-03-25T15:07:47.000Z
`GH_FORCE_TTY` only affects stdout, not stderr, so this check was failing and the flag was being ignored. I also checked for similar problem in other files but everything else seemed stderr or stdin related. closes cli#5354
diff --git a/pkg/cmd/pr/view/view.go b/pkg/cmd/pr/view/view.go
@@ -98,7 +98,7 @@ func viewRun(opts *ViewOptions) error {
 		return err
 	}
 
-	connectedToTerminal := opts.IO.IsStdoutTTY() && opts.IO.IsStderrTTY()
+	connectedToTerminal := opts.IO.IsStdoutTTY()
 
 	if opts.BrowserMode {
 		openURL := pr.URL

Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,7 @@ func viewRun(opts *ViewOptions) error {`
`98`	`98`	`return err`
`99`	`99`	`}`
`100`	`100`
`101`		`- connectedToTerminal := opts.IO.IsStdoutTTY() && opts.IO.IsStderrTTY()`
	`101`	`+ connectedToTerminal := opts.IO.IsStdoutTTY()`
`102`	`102`
`103`	`103`	`if opts.BrowserMode {`
`104`	`104`	`openURL := pr.URL`