scope error handling

meiji163 · mislav · web-flow · commit f7b4588d0920 · 2021-10-15T08:35:33.000-07:00
Co-authored-by: Mislav Marohnić &lt;mislav@github.com&gt;
diff --git a/pkg/cmd/repo/delete/http.go b/pkg/cmd/repo/delete/http.go
@@ -25,13 +25,8 @@ func deleteRepo(client *http.Client, repo ghrepo.Interface) error {
 	}
 	defer resp.Body.Close()
 
-	err = api.HandleHTTPError(resp)
-
-	if resp.StatusCode == 403 {
-		return fmt.Errorf(`%w
-Try authorizing the "delete_repo" scope with "gh auth refresh -s delete_repo".`, err)
-	} else if resp.StatusCode > 299 {
-		return err
+	if resp.StatusCode > 299 {
+		return api.HandleHTTPError(resp)
 	}
 
 	return nil

Original file line number	Diff line number	Diff line change
`@@ -25,13 +25,8 @@ func deleteRepo(client *http.Client, repo ghrepo.Interface) error {`
`25`	`25`	`}`
`26`	`26`	`defer resp.Body.Close()`
`27`	`27`
`28`		`- err = api.HandleHTTPError(resp)`
`29`		`-`
`30`		`- if resp.StatusCode == 403 {`
`31`		- return fmt.Errorf(`%w
`32`		-Try authorizing the "delete_repo" scope with "gh auth refresh -s delete_repo".`, err)
`33`		`- } else if resp.StatusCode > 299 {`
`34`		`- return err`
	`28`	`+ if resp.StatusCode > 299 {`
	`29`	`+ return api.HandleHTTPError(resp)`
`35`	`30`	`}`
`36`	`31`
`37`	`32`	`return nil`