Avoid macOS prompt to allow incoming connections in liveshare tests

mislav · mislav · commit d68126af9970 · 2021-10-14T14:23:36.000+02:00
Listening on the localhost interface disallows connections from the
outside anyway, so the OS firewall doesn't have to prompt whether the
user wants to allow incoming connections to the Go process.
diff --git a/pkg/liveshare/port_forwarder_test.go b/pkg/liveshare/port_forwarder_test.go
@@ -46,7 +46,7 @@ func TestPortForwarderStart(t *testing.T) {
 	}
 	defer testServer.Close()
 
-	listen, err := net.Listen("tcp", ":8000")
+	listen, err := net.Listen("tcp", "127.0.0.1:8000")
 	if err != nil {
 		t.Fatal(err)
 	}

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ func TestPortForwarderStart(t *testing.T) {`
`46`	`46`	`}`
`47`	`47`	`defer testServer.Close()`
`48`	`48`
`49`		`- listen, err := net.Listen("tcp", ":8000")`
	`49`	`+ listen, err := net.Listen("tcp", "127.0.0.1:8000")`
`50`	`50`	`if err != nil {`
`51`	`51`	`t.Fatal(err)`
`52`	`52`	`}`