Add int32 validation to milestone numbers

quiye · quiye · commit d4e6fc11d735 · 2020-10-13T08:36:47.000+09:00
diff --git a/api/queries_issue.go b/api/queries_issue.go
@@ -251,8 +251,8 @@ func IssueList(client *Client, repo ghrepo.Interface, state string, labels []str
 
 	if milestoneString != "" {
 		var milestone *RepoMilestone
-		if milestoneNumber, err := strconv.Atoi(milestoneString); err == nil {
-			milestone, err = MilestoneByNumber(client, repo, milestoneNumber)
+		if milestoneNumber, err := strconv.ParseInt(milestoneString, 10, 32); err == nil {
+			milestone, err = MilestoneByNumber(client, repo, int32(milestoneNumber))
 			if err != nil {
 				return nil, err
 			}
diff --git a/api/queries_repo.go b/api/queries_repo.go
@@ -840,7 +840,7 @@ func MilestoneByTitle(client *Client, repo ghrepo.Interface, title string) (*Rep
 	return nil, fmt.Errorf("no milestone found with title %q", title)
 }
 
-func MilestoneByNumber(client *Client, repo ghrepo.Interface, number int) (*RepoMilestone, error) {
+func MilestoneByNumber(client *Client, repo ghrepo.Interface, number int32) (*RepoMilestone, error) {
 	var query struct {
 		Repository struct {
 			Milestone *RepoMilestone `graphql:"milestone(number: $number)"`

Original file line number	Diff line number	Diff line change
`@@ -840,7 +840,7 @@ func MilestoneByTitle(client Client, repo ghrepo.Interface, title string) (Rep`
`840`	`840`	`return nil, fmt.Errorf("no milestone found with title %q", title)`
`841`	`841`	`}`
`842`	`842`
`843`		`-func MilestoneByNumber(client Client, repo ghrepo.Interface, number int) (RepoMilestone, error) {`
	`843`	`+func MilestoneByNumber(client Client, repo ghrepo.Interface, number int32) (RepoMilestone, error) {`
`844`	`844`	`var query struct {`
`845`	`845`	`Repository struct {`
`846`	`846`	Milestone *RepoMilestone `graphql:"milestone(number: $number)"`